Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B35EAC433C8
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Wright Feng <wright.feng@cypress.com>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list@cypress.com,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        chi-hsien.lin@cypress.com, Kurt Lee <kurt.lee@cypress.com>
Subject: Re: [PATCH] brcmfmac: Support DPP feature
References: <20201005070857.83974-1-wright.feng@cypress.com>
Date:   Tue, 06 Oct 2020 09:00:42 +0300
In-Reply-To: <20201005070857.83974-1-wright.feng@cypress.com> (Wright Feng's
        message of "Mon, 5 Oct 2020 02:08:57 -0500")
Message-ID: <87tuv7c2r9.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Wright Feng <wright.feng@cypress.com> writes:

> From: Kurt Lee <kurt.lee@cypress.com>
>
> Let driver parse DPP frames from upper layer and do corresponding
> configuration to firmware.
>
> Signed-off-by: Kurt Lee <kurt.lee@cypress.com>

Wright's s-o-b missing.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing

> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -63,6 +63,9 @@
>  #define RSN_CAP_MFPC_MASK		BIT(7)
>  #define RSN_PMKID_COUNT_LEN		2
>  
> +#define DPP_AKM_SUITE_TYPE		2
> +#define WLAN_AKM_SUITE_DPP		SUITE(WLAN_OUI_WFA, DPP_AKM_SUITE_TYPE)

Shouldn't these be in include/linux/ieee80211.h?

> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcmu_wifi.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcmu_wifi.h
> @@ -233,6 +233,11 @@ static inline bool ac_bitmap_tst(u8 bitmap, int prec)
>  
>  #define WPA3_AUTH_SAE_PSK	0x40000	/* SAE with 4-way handshake */
>  
> +#define WFA_AUTH_DPP		0x200000 /* WFA DPP AUTH */

I assume this is Broadcom specific and this is the correct file for this
define. Please correct me if I'm wrong.

> +#define WFA_OUI			"\x50\x6F\x9A"	/* WFA OUI */

You should use this:

include/linux/ieee80211.h:#define WLAN_OUI_WFA                  0x506f9a

> +#define DPP_VER			0x1A	/* WFA DPP v1.0 */

Shouldn't this be also in include/linux/ieee80211.h?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches