Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1057977pxu; Thu, 8 Oct 2020 02:04:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuPpo/mUqOXCHVUqYAdAqiGibd5RTVZqcdoBvDadfyYG9klLkBVNd2R9dz6P7ExkdLxFqX X-Received: by 2002:aa7:dd01:: with SMTP id i1mr8139214edv.84.1602147859866; Thu, 08 Oct 2020 02:04:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602147859; cv=none; d=google.com; s=arc-20160816; b=iE6MW4ABcxz4UCwH2eqWTytzOcQDeo+osvxyIqDKwsBIgF3T710Jy4ukXIRpE4y81I r68Pxi80A76JJedpQOe8HYOem0iVp7u3ZGo6js5uTOHhonOhI0lF4WBI1jThkI54PINh AXop+67/Oo9pNVWKYtOcMRNb1tysKz0O0PUdD3bO0TG9naAMTSxSRDIS4rKS/33LVGyQ yAUl7VK2WUqYSKOxm3yJBJOr9/44wJA0UPYuSw+6Zdp36PrvmxFg4q8oK48N38gtyEjV GF4+2s2lOHxJsrG2fHCrC8xpQ+SZXny4oYOggJ7GicViQAIu6fMln3IU8bSWYLKxL34H GosQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=HvVW4Ibc1AZlG7vpyonPenYkN6YL4Fjj4Mvi0YaWdno=; b=jT6Tq1YU1h/EkAwUAKrUgTucA0DovM9tZ2wq18ytcc4DTBQGpf1n/m/OKkT4e8C1zX DqSG66Fm/W1HMEG7IuGyDHAP4Q430qoQl+6oJ6224IqUBXFC6MIMakeIYNvT4AS+9v7e 6LN52qt6foY2fL/4+6SOLfmOWps4PRAssDghFMjHucu8D/IJUu877v16zKLt/vhDFq4F DQ0WcvsTE0BTXbwKXonsHXxO2ZCIVaFuQDvcivcUiUw+Ta0//x3EjqyO2eD7ADJMBhon Ncp3F5y5PVKucZ8Q4J1Kf/fkm4M8dOX7BAGCHl8hZbfWaR3ff4GR6gn2/pneG0Lq9sT2 2K6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u17si3119030eda.185.2020.10.08.02.03.54; Thu, 08 Oct 2020 02:04:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726141AbgJHIjK (ORCPT + 99 others); Thu, 8 Oct 2020 04:39:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbgJHIjJ (ORCPT ); Thu, 8 Oct 2020 04:39:09 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49A5C061755 for ; Thu, 8 Oct 2020 01:39:09 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kQRS7-001UWo-U5; Thu, 08 Oct 2020 10:39:08 +0200 Message-ID: <39d5d6f1a5dad25d20a45c46dffdcd45cd28286e.camel@sipsolutions.net> Subject: Re: [PATCH v2 2/2] mac80211: initialize last_rate for S1G STAs From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless Date: Thu, 08 Oct 2020 10:39:02 +0200 In-Reply-To: <20201005164522.18069-2-thomas@adapt-ip.com> References: <20201005164522.18069-1-thomas@adapt-ip.com> <20201005164522.18069-2-thomas@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-10-05 at 09:45 -0700, Thomas Pedersen wrote: > last_rate is initialized to zero by sta_info_alloc(), but > this indicates legacy bitrate for the last TX rate (and > invalid for the last RX rate). To avoid a warning when > decoding the last rate as legacy (before a data frame > has been sent), initialize them as S1G MCS. Oh, I see, this fixes the warning ... OK, never mind, I'll just apply both. johannes