Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 02/10] mt76: testmode: add snr attribute in rx statistics
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
References: <20201008112904.10620-1-shayne.chen@mediatek.com>
 <20201008112904.10620-2-shayne.chen@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <e0e661ed-f351-043d-d151-bf30dd766925@nbd.name>
Date:   Sun, 11 Oct 2020 21:37:25 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201008112904.10620-2-shayne.chen@mediatek.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-10-08 13:28, Shayne Chen wrote:
> Support to display snr value when dumping rx statistics.
> 
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/testmode.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/testmode.h b/drivers/net/wireless/mediatek/mt76/testmode.h
> index 02c9495..4015f1d 100644
> --- a/drivers/net/wireless/mediatek/mt76/testmode.h
> +++ b/drivers/net/wireless/mediatek/mt76/testmode.h
> @@ -101,6 +101,7 @@ enum mt76_testmode_stats_attr {
>   * @MT76_TM_RX_ATTR_RCPI: received channel power indicator (array, u8)
>   * @MT76_TM_RX_ATTR_IB_RSSI: internal inband RSSI (array, s8)
>   * @MT76_TM_RX_ATTR_WB_RSSI: internal wideband RSSI (array, s8)
> + * @MT76_TM_RX_ATTR_SNR: signal-to-noise ratio (s32)
I think u8 makes more sense than s32 as a type for snr.

- Felix