Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3662805pxu;
        Sun, 11 Oct 2020 19:17:57 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxVU3YaRvE7VRfMYQCbGxSaMMSkFZm49NqeFEKVslcmFmdKtk/IkbXGgF+fOiEIBEY4eeIE
X-Received: by 2002:a17:906:4a97:: with SMTP id x23mr25273096eju.471.1602469077502;
        Sun, 11 Oct 2020 19:17:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1602469077; cv=none;
        d=google.com; s=arc-20160816;
        b=qgjzl33hVyP/OkLDs3LaF5YtXwtExRWgaaez7IX6Ymr7OZHOWzW6hVktSu5Tt8uDZ+
         aP6R16W+0FaycHu5a6CMtmWBadKYb0FvVxhsnuqW/2c1fYI+EXb6/1TT2JZq+dT+edmH
         hekPMEyOlrHPkgi6ZBwOgbC0mK11RESUJqsCiAqoNH8YXTe9lA0rGItiFjoEAV0hCcxL
         j1JCZmoccSDtfV3xwrqPsEhGtD13q2fl4ynFSISVppGBpbdZwwQ6L1fTfQUT2L+qXvWe
         Gk8PrnHL57Qb8Nc62KeLLofioyiOx8qaBPzO2TbYM0Giiz68izHH2zRweoyUTfKgnA0P
         QMDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=s5SNqVq+ZBe6hjQiLpkfiBRZRF78JD0zHMy8UuCWRiY=;
        b=t71XV2P5f97Nt7u75g4ERlp3ms0ZFWch/P2E5j0EI28M+JXGK0WofOL2xcWr065a5P
         HAZ0gCNjuYzPoctxasmXM45ATgIDUGERDVvFRKrZ4afr11bz66IM/iDq19jO8MxJPPOK
         UJUK7QjhQ1wp46keTZSqSnZfO9ppQ2XqCR5cviEpb+lerx0aSgRSQWA+f2Y6GkkdHLQ1
         7t48khoHxAzkjeju2TLTOR1qOvjoKilgatZ9GbuxW4lCtyOgPqtNGR3BmeZsfGHGqDSz
         Bd0A23rykJR/kbK2ThrVNUKd62u+FElawo1t7paZuefJZsZwtwaSqVQrJyLbte4kPyjF
         cS/Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=HbAJpZ60;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id ch15si13454692ejb.52.2020.10.11.19.17.33;
        Sun, 11 Oct 2020 19:17:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=HbAJpZ60;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2387632AbgJKWKd (ORCPT <rfc822;a.karthikeyansoft@gmail.com>
        + 99 others); Sun, 11 Oct 2020 18:10:33 -0400
Received: from mail.kernel.org ([198.145.29.99]:46166 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2387409AbgJKWKd (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
        Sun, 11 Oct 2020 18:10:33 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id D12CB2078B;
        Sun, 11 Oct 2020 22:10:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1602454232;
        bh=s5SNqVq+ZBe6hjQiLpkfiBRZRF78JD0zHMy8UuCWRiY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=HbAJpZ6018DBKV/l48njs8OL9/FllGvxUgDG8y1p32816ZlZ7gOIkkLIjU7IAfzDF
         2QUcmqA/zF3j9ITlIHLZgFmJWBb6yjdP6LrUeZwu5dy8T8okZRM99so5ko9gjewUvK
         /fH4L6+ICSrkoy+rKqzIM+M5ZF3AZwfiDBhd8oLU=
Date:   Sun, 11 Oct 2020 15:10:30 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     David Miller <davem@davemloft.net>,
        =?UTF-8?B?QmrDuHJu?= Mork <bjorn@mork.no>,
        Oliver Neukum <oneukum@suse.com>,
        Igor Mitsyanko <imitsyanko@quantenna.com>,
        Sergey Matyukevich <geomatsi@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <nikolay@nvidia.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        Pravin B Shelar <pshelar@ovn.org>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        linux-rdma@vger.kernel.org,
        Linux USB Mailing List <linux-usb@vger.kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 00/12] net: add and use function
 dev_fetch_sw_netstats for fetching pcpu_sw_netstats
Message-ID: <20201011151030.05ad88dd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <a46f539e-a54d-7e92-0372-cd96bb280729@gmail.com>
References: <a46f539e-a54d-7e92-0372-cd96bb280729@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Sun, 11 Oct 2020 21:34:58 +0200 Heiner Kallweit wrote:
> In several places the same code is used to populate rtnl_link_stats64
> fields with data from pcpu_sw_netstats. Therefore factor out this code
> to a new function dev_fetch_sw_netstats().

FWIW probably fine to convert nfp_repr_get_host_stats64() as well, just
take out the drop counter and make it a separate atomic. If you're up
for that.