Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3663081pxu; Sun, 11 Oct 2020 19:18:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+hZ44Mpq4KU2JH7/nmfeS/ovT+N1fsO1lrjl8sl/FIcYAMK9t8ETc6U7EvSxFXBEcv6Ux X-Received: by 2002:aa7:d1cc:: with SMTP id g12mr11861306edp.195.1602469121696; Sun, 11 Oct 2020 19:18:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602469121; cv=none; d=google.com; s=arc-20160816; b=wFq1YSyXdTk601eCphk2/gc+aJ1JOxD+lqGbCfSyIOdXo9bhl4ROTCrw3/yrl+JQk5 9XzvEKkDhEWBX9kyJO5v+L8SygSZUtShJYNbPDyPcgLx2OaEIdu6efeC/Cx1fXpzywN5 iRoEdOmLXOM6Jy49LXqjPJv/KqIqvTnIdRsmkNp67IWB/Ll2GgQidRXlu/YK4YiRlH+b zzhTmyTDOVj2fW0fzZuRM2XapPpZgzj16kIwAWCFuWdMHuOjgkLXfv08u2yq+rOOi9LS 7EcUFBWV9xXo31EhU/UCijVyAmnvApP7y767N1Tn8q80mI7DvmfQqe+HvpgtTbwMDv0G bj/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=//RhQ8PjosEJsL6xOjHB0IpmZCSmG4U7JZ9L/Rz9nqc=; b=YjAmDd4/p1hq6sviHiLAVULH9z9woGme9EahD9C2resK0cbkUNOWdh50ASXi547HXX osU0qKRNDTfHom1Ku7dLI2ZC5fxBx9WhBxM/QYHDF2l77K2UiBkMI+v9ck3QTpkiKYXV 6Rg2G4eRtfL+BObEDrd4EB030lUPOIsUpzrbb4i0Zh1CW8bBUENNgJ7tW9jQqzlesRjx N6nIfSFZGn2qdNjcR62auB+uhPPnz84ILFQLayXGdvXncsGcxYd9gsCYTcUvEQIqSaGX Eri2pzSNEwvqEKe/JKZ+smKXIL98p89hBvU4t8s4d6UXcTGTIzQ77ndUP0tVvcGWFa0I xK5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DXXI2vnw; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si12201586edq.44.2020.10.11.19.18.17; Sun, 11 Oct 2020 19:18:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DXXI2vnw; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387743AbgJKWly (ORCPT + 99 others); Sun, 11 Oct 2020 18:41:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:33132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387717AbgJKWlx (ORCPT ); Sun, 11 Oct 2020 18:41:53 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F8FB2074A; Sun, 11 Oct 2020 22:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602456113; bh=KjfGjYsSnfWIwHrASEVqiRbvBtfZz9AkJ6pI70LmAbY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DXXI2vnw0yJuPJ+UvqE/MJmockTPIdo7j2X4VD6cjbrAv9qt0TDpFCu4E2diTbvCa shuUVYDttC88i8EshqLCBbS7Pgnjatcg9oMtKR2Gt/ZosE3SnuV5Kkmq5YtSR7y6jw Db1nukMbgdyTCNrBWKddb4xAZNlStmyMTtVuHomM= Date: Sun, 11 Oct 2020 15:41:50 -0700 From: Jakub Kicinski To: Heiner Kallweit Cc: David Miller , =?UTF-8?B?QmrDuHJu?= Mork , Oliver Neukum , Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Alexey Kuznetsov , Hideaki YOSHIFUJI , Johannes Berg , Pravin B Shelar , Steffen Klassert , Herbert Xu , "netdev@vger.kernel.org" , linux-rdma@vger.kernel.org, Linux USB Mailing List , linux-wireless , bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Message-ID: <20201011154150.6cad3758@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1f1dceab-bab0-ff9e-dae6-ed35be504a9c@gmail.com> References: <20201011151030.05ad88dd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <1f1dceab-bab0-ff9e-dae6-ed35be504a9c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 12 Oct 2020 00:29:52 +0200 Heiner Kallweit wrote: > On 12.10.2020 00:10, Jakub Kicinski wrote: > > On Sun, 11 Oct 2020 21:34:58 +0200 Heiner Kallweit wrote: > >> In several places the same code is used to populate rtnl_link_stats64 > >> fields with data from pcpu_sw_netstats. Therefore factor out this code > >> to a new function dev_fetch_sw_netstats(). > > > > FWIW probably fine to convert nfp_repr_get_host_stats64() as well, just > > take out the drop counter and make it a separate atomic. If you're up > > for that. > > > Looking at nfp_repr_get_host_stats64() I'm not sure why the authors > decided to add a 64bit tx drop counter, struct net_device_stats has > an unsigned long tx_dropped counter already. And that the number of > dropped tx packets exceeds 32bit (on 32bit systems) seems not very > likely. struct net_device::stats? That's not per-cpu. Or do you mean struct net_device::tx_dropped? That'd work nicely.