Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <000000000000021e6b05b0ea60bd@google.com> <00000000000069707b05b13da267@google.com>
 <20201009185548.GA546075@rowland.harvard.edu>
In-Reply-To: <20201009185548.GA546075@rowland.harvard.edu>
From:   Andrey Konovalov <andreyknvl@google.com>
Date:   Mon, 12 Oct 2020 14:58:34 +0200
Message-ID: <CAAeHK+y11k5rj9n=+Z7Y9bYjsWBoqaXfsystF3pCWgTPaRxrjg@mail.gmail.com>
Subject: Re: WARNING in hif_usb_send/usb_submit_urb
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     syzbot <syzbot+f5378bcf0f0cab45c1c6@syzkaller.appspotmail.com>,
        QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
        eli.billauer@gmail.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        gustavoars@kernel.org, ingrassia@epigenesys.com,
        LKML <linux-kernel@vger.kernel.org>,
        USB list <linux-usb@vger.kernel.org>,
        Oliver Neukum <oneukum@suse.com>,
        linux-wireless@vger.kernel.org,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Takashi Iwai <tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 9, 2020 at 8:55 PM Alan Stern <stern@rowland.harvard.edu> wrote:
>
> To the ath9k_htc maintainers:
>
> This is an attempt to fix a bug detected by the syzbot fuzzer.  The bug
> arises when a USB device claims to be an ATH9K but doesn't have the
> expected endpoints.  (In this case there was a bulk endpoint where the
> driver expected an interrupt endpoint.)  The kernel needs to be able to
> handle such devices without getting an internal error.
>
> On Fri, Oct 09, 2020 at 07:19:19AM -0700, syzbot wrote:
> > syzbot has found a reproducer for the following issue on:
> >
> > HEAD commit:    6c8cf369 usb: typec: Add QCOM PMIC typec detection driver
>
> Andrey, why doesn't syzbot put a 12-digit commit ID here?

No particular reason, I think. Makes sense to change it to 12, as it's
the recommended minimum AFAIU. I've a bug to track this here:
https://github.com/google/syzkaller/issues/2184

Thank you!