Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: pradeepc=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 12 Oct 2020 09:41:25 -0700
From:   Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] mac80211: save he oper info in bss config for AP and mesh
In-Reply-To: <f6daeb86f2cf83f57785e08b86fecfdf6410de46.camel@sipsolutions.net>
References: <20200715030937.25290-1-pradeepc@codeaurora.org>
 (sfid-20200715_050947_264568_478AF07B)
 <f6daeb86f2cf83f57785e08b86fecfdf6410de46.camel@sipsolutions.net>
Message-ID: <561813d2d5a5268261c48e51a6ad90b9@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk


>> -u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def 
>> *chandef)
>> +u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def 
>> *chandef,
>> +			       struct ieee80211_sub_if_data *sdata)
>>  {
>>  	struct ieee80211_he_operation *he_oper;
>>  	struct ieee80211_he_6ghz_oper *he_6ghz_op;
>> @@ -3056,6 +3057,7 @@ u8 *ieee80211_ie_build_he_oper(u8 *pos, struct 
>> cfg80211_chan_def *chandef)
>>  	he_oper = (struct ieee80211_he_operation *)pos;
>>  	he_oper->he_oper_params = cpu_to_le32(he_oper_params);
>> 
>> +	sdata->vif.bss_conf.he_oper.params = he_oper_params;
> 
> I think these changes are inappropriate. This is a helper function to
> build something, not to store the data. Please change the callers
> instead.
> 
> johannes
Hi Johannes,

Sorry for late response..

Thanks for the review.. I have tried to address the review comments
provided and created new series @ 
https://patchwork.kernel.org/cover/11824871/

Thanks
Pradeep