Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp294061pxu; Wed, 14 Oct 2020 01:11:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy52vNJt2CWqd1AEeztBh+2gCEzTxVPrGGem4NuQwdFW+IBHnLlgD4GiqyhWIFdCWrze92C X-Received: by 2002:a50:852a:: with SMTP id 39mr3965352edr.63.1602663113551; Wed, 14 Oct 2020 01:11:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602663113; cv=none; d=google.com; s=arc-20160816; b=Z+ZvEMaHDnY0nP/aQvkjaaWKR8PrRcDm0Fj3fWPOLdLtw9Qxv1jhVg+abht71gg6a/ 8zc+t4SYp8pLLdiPHvze8p60NCaf84Wg0SbyNS6O+N4wUr/Epo+egf5aCcFNG6BhDNOb /8epeZO2d6wEIa32EAWNtBsIROUFB4cWBDSpdl0JVCP8T0j+TTJ57TXYAl2wMLKtE0wC VRIjBTudYQb+7/5i3smLDoiqZS59yKfhba71qtIyIRuKJcCbKf2NrI93hbo9n84SlnCr jW2h3SQw+1c2Cfd7neSbVxIpjB3XfxEwUvzDAdZEpL9tN8m+s4pgjjHSA9unM4cwtM28 SlSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IGdwqlpp0h6qu3lCcmyQqiVX4OzwMUSZgw4LZy3fI90=; b=iQu1zOEVhs6L/Jv/Kcnt6TohuI1wLSqZ67wqWX/s3Pjg4ysPnuiN8V4HkQoXUJMLJc ZgjyqpCiVJKETrzkYQwCB153mzeqSx/4XoU/IxhQuLU0gVRHiKQbO1ibZy5M1r5EsLlm 2yUsOf0yUH+BXP45pUv+Ni0uaBvYhXasBHcKol0Lp0toctDPX4KTkdjcjhZB9PqarOYP S3uH7mfK1MkBZJtnsKKR3DTk+d4+cxbOBUu4ZrNo+bKuzZmbqlCbA+6lXDQUmsWZqydC UiRK5SA5h1BXhKKI6SjSYkhBodTRNwmxu3HII4lqB+kfEuRpWx2lM1uKavfkRITA9ITZ kGOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nIH5M255; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si1582359ejt.420.2020.10.14.01.11.23; Wed, 14 Oct 2020 01:11:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nIH5M255; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730528AbgJNAjy (ORCPT + 99 others); Tue, 13 Oct 2020 20:39:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:54422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbgJNAjx (ORCPT ); Tue, 13 Oct 2020 20:39:53 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B88D921D40; Wed, 14 Oct 2020 00:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602635993; bh=CFDyw8SnopRjOQTv0trN9Zq7Ipl3I4xqiXTNATXIglw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nIH5M255GwfPrbDQw7nysc73Kb4lCHwXLccsHykUZ7j00IujiVWARwvphAzSdGbQP IuFY/nrDgxcHpobYsKZV6FppHfBO0ll8YvibDiZtw3KPKZ62M3T+AvO8PaoLzgQAhZ If59RIypN65WfSLeZIhy6Wa8MEgwOEApPF5WA8eU= Date: Tue, 13 Oct 2020 17:39:51 -0700 From: Jakub Kicinski To: Heiner Kallweit Cc: David Miller , =?UTF-8?B?QmrDuHJu?= Mork , Oliver Neukum , Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Alexey Kuznetsov , Hideaki YOSHIFUJI , Johannes Berg , Pravin B Shelar , Steffen Klassert , Herbert Xu , "netdev@vger.kernel.org" , linux-rdma@vger.kernel.org, Linux USB Mailing List , linux-wireless , bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Message-ID: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: > In several places the same code is used to populate rtnl_link_stats64 > fields with data from pcpu_sw_netstats. Therefore factor out this code > to a new function dev_fetch_sw_netstats(). > > v2: > - constify argument netstats > - don't ignore netstats being NULL or an ERRPTR > - switch to EXPORT_SYMBOL_GPL Applied, thank you!