Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authenticated-By: 
From:   Andy Huang <tehuang@realtek.com>
To:     "'Dan Carpenter'" <dan.carpenter@oracle.com>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [bug report] rtw88: add dump firmware fifo support
Thread-Topic: [bug report] rtw88: add dump firmware fifo support
Thread-Index: AQHWoWx0Kgs2XDNhbUWYN/LN0gZwvamWXsoA
Date:   Wed, 14 Oct 2020 02:24:41 +0000
Message-ID: <faef9a43454b4aae819244eb5a90571b@realtek.com>
References: <20201013142330.GA490753@mwanda>
In-Reply-To: <20201013142330.GA490753@mwanda>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

> Hello Tzu-En Huang,
> 
> The patch 0fbc2f0f34cc: "rtw88: add dump firmware fifo support" from Sep 25,
> 2020, leads to the following static checker warning:
> 
> 	drivers/net/wireless/realtek/rtw88/fw.c:1485 rtw_fw_dump_fifo()
> 	warn: this array is probably non-NULL. 'rtwdev->chip->fw_fifo_addr'
> 
> drivers/net/wireless/realtek/rtw88/fw.c
>   1482  int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr,
> u32 size,
>   1483                       u32 *buffer)
>   1484  {
>   1485          if (!rtwdev->chip->fw_fifo_addr) {
>                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Delete this check?
> 
>   1486                  rtw_dbg(rtwdev, RTW_DBG_FW, "chip not
> support dump fw fifo\n");
>   1487                  return -ENOTSUPP;
>   1488          }
>   1489
>   1490          if (size == 0 || !buffer)
>   1491                  return -EINVAL;
> 
> regards,
> dan carpenter

Thanks for the report, and I saw Tom had sent a patch to fix it. I acked on the patch.

Tzu-En