Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp308191pxu; Wed, 14 Oct 2020 01:41:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0E5JOWAH9puQ4xmDNrXcaeY5rg+fex1vqxdnKfxAlSRqjE4pM1A27wJenIjNWx78bHwZx X-Received: by 2002:a17:906:aec1:: with SMTP id me1mr4303228ejb.225.1602664870163; Wed, 14 Oct 2020 01:41:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602664870; cv=none; d=google.com; s=arc-20160816; b=PS8PIGYHonf5zKkx+QV08FDH9QvYRl2ZsgTVGG3B6AGz3rfrX3AIcnWzEmxBvGglfv oqGpdKw4FQn8xLSCmKOjZZXa64Z/ys/1kMGcdK58FNKpwgwtogcLoSavtj0O4fIcDJLC hGsuSBuEu9uphC0SS3h6UYF2mTKxaaah1XJLqvXNWrfYDpHuaercurl4rf/AHy+AneKg TzLNiW+B2PNaiYHNa7PLseF8+3YX5xJzg6bEa2cxeGGx+PXbUmryBg/xMUHVTQNknO5J EgbKjmA/wG+xDqbN5wzBbX7pdF9OBga/qAw1twSQYdfpZ9tE8kDUiTz+KH5KYFyU7j0D orPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=w10HAUvHzI4K2dPPA6eBw0IIFtp11qCCa0wUzKaUmD8=; b=Y63/v+BRfxotdHt5HZNFG0OD/mnsrJowche6RlhVJ5+DaDuHSyOCwAMdc1D8UjEQi1 +HfkUFYsC+qxSkw59trFXFY4cHkkgdTMA9A1gf1MI2Nxf+J1NWVpy9Va58Fa4gEHjeps fWVnYn5eJ24RYVWbpGGFHRmhWv+ylNj+3t3zd8XzmkTXx1giZ9mKB6od2RTgUr76tY+K 1DHwCvK4tryFs98oz5uql7Qr1s1lAfHSruvHIDCnLmZ/jZGVbKzsr+bvuYbXlhLjepQ9 3FFwfmYPu4zGJ5eI8QlIPq4RQCQ2tjF+mVPm0WGuFXxpcJh5H3m1Q79tBY/F963GSw02 bLCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cKsoRdZk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si1736050ejb.156.2020.10.14.01.40.45; Wed, 14 Oct 2020 01:41:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cKsoRdZk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbgJNFmz (ORCPT + 99 others); Wed, 14 Oct 2020 01:42:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:44624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbgJNFmz (ORCPT ); Wed, 14 Oct 2020 01:42:55 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 936BB2177B; Wed, 14 Oct 2020 05:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602654174; bh=w10HAUvHzI4K2dPPA6eBw0IIFtp11qCCa0wUzKaUmD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cKsoRdZk0/7P9W5KQIcB78oxj7gSK1YWQM+hrVcStVlKqV5euxdawGaIKjsJO+YUU /usInNdGonQCzHNv/4cuzYg3D1kAHdZbtEGHplDqaWK5j6M3yEug5qW6hLhVGcPu6C Ur12VOGAV45LDfAlhlt9kErfzTLPyFZ2XWjKnbEc= Date: Wed, 14 Oct 2020 08:42:50 +0300 From: Leon Romanovsky To: Jakub Kicinski Cc: Heiner Kallweit , David Miller , =?iso-8859-1?Q?Bj=F8rn?= Mork , Oliver Neukum , Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Roopa Prabhu , Nikolay Aleksandrov , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Alexey Kuznetsov , Hideaki YOSHIFUJI , Johannes Berg , Pravin B Shelar , Steffen Klassert , Herbert Xu , "netdev@vger.kernel.org" , linux-rdma@vger.kernel.org, Linux USB Mailing List , linux-wireless , bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats Message-ID: <20201014054250.GB6305@unreal> References: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013173951.25677bcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote: > On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: > > In several places the same code is used to populate rtnl_link_stats64 > > fields with data from pcpu_sw_netstats. Therefore factor out this code > > to a new function dev_fetch_sw_netstats(). > > > > v2: > > - constify argument netstats > > - don't ignore netstats being NULL or an ERRPTR > > - switch to EXPORT_SYMBOL_GPL > > Applied, thank you! Jakub, Is it possible to make sure that changelogs are not part of the commit messages? We don't store previous revisions in the git repo, so it doesn't give too much to anyone who is looking on git log later. The lore link to the patch is more than enough. 44fa32f008ab ("net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats") Thanks