Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3269654pxu; Mon, 19 Oct 2020 08:07:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAI3BOWuLBCPSP7UGO8mQBhRk/ult5XlnDFssFziFa/TrBgvd+0FAgveUwQQX5Lad51SGj X-Received: by 2002:a17:907:4301:: with SMTP id nh1mr280048ejb.397.1603120030296; Mon, 19 Oct 2020 08:07:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603120030; cv=none; d=google.com; s=arc-20160816; b=wZWmYuOhkVr7ao+g24mfCiXAVQJlthXCpjRVCdQUVFnrO8nyBLDeTuM3C91gV7Evth obK3yRsmX1ix1GlGJE/Bo+1B/M+IoSuo2nOv5TQQYbFjlxD9WUCa6yZQnfm/MOccWBq3 JECVsI/79Zw4EEDwTOAIvcooIzh/F1syqr9VZPinYviwPDThE3JUVXfUrKA8hcSFkchC R8GBVJbs6eFNXwTAnFNVRYYE7TCFIf+BS2WDqK6aJyQXCemU41Buw3b3jsMReBbQhV7j 9rLuaKWUp7hSfTnX8lD6asLToOqgCS8VaDxCtEcz+i3sazRQkHvjVHzBAJGZnpWHMfq0 NSLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=u7a+QTs7KK/u/ERH7j5xA9SS8bPqHeGvDR9yK7S64mA=; b=cjdgBfYCx6l3lxHRJT82SLZknM9JYby3hL3aMc27JiXEl1CWZKHw77JWckhBM9rUV1 lHsMbX+p1v9VSUWSSBFTMM3sWwqpGfOsh0RYp0UlINzDptbLEWBISRC/6PsXxUKqTOxv N8/teDFumsMrknwVjuZiYGNsU/ZqUFeMD6iKZcOSTFYvWyf19GF0Ze2jY4BpKsebYtdm J4sdUdXhaNlLxC8QRejo2f6bowTyxPKQ48fn5XOEnUAk4io5NcDBMbHZTIHdQa8g8f15 K9jahcMJ2kaGgb4h/K5qNy2sH4mGcq2NJUs81xAFaQVw+opVqwCuoIrmeVJuhm9AieTM UPgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Iub9DU4x; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si8052699edo.519.2020.10.19.08.06.34; Mon, 19 Oct 2020 08:07:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Iub9DU4x; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729842AbgJSPFY (ORCPT + 99 others); Mon, 19 Oct 2020 11:05:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60239 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729781AbgJSPFX (ORCPT ); Mon, 19 Oct 2020 11:05:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603119921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=u7a+QTs7KK/u/ERH7j5xA9SS8bPqHeGvDR9yK7S64mA=; b=Iub9DU4xUbXuoAXTCM2Vili+0t0i5+wHBuwJ5KFB1nt1owNPIB3axoLWJ6Ixh49oJ3KYxo M+Naiv1wrqy7GJJuKXOhXkyqO2nwAaejrrTJW7Pr3yjBbcUUlHwUj1g6x8Qv2AReOh4Psj Srt9Of62KVCyBbf2DoW6J6wBr+czOZg= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-AZxnWC2hNVq7sBoEODQpjg-1; Mon, 19 Oct 2020 11:05:16 -0400 X-MC-Unique: AZxnWC2hNVq7sBoEODQpjg-1 Received: by mail-qk1-f197.google.com with SMTP id z16so1126089qkg.15 for ; Mon, 19 Oct 2020 08:05:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=u7a+QTs7KK/u/ERH7j5xA9SS8bPqHeGvDR9yK7S64mA=; b=Zk070YoMBwZO3tt77bPs67C3hXNjKt9JCUxvvbHuYbzZkR0nsTge+SbVG81P5xSGKo 5H4cZ0SULIYbqk/wPy+8qxuxpUucrK83CDLrB/joy4FGOc03dPEekTE1lQR2ZZJzlFqo AfRVIlrMqFQT1YyW+zxXj9vpvq+N5IGR6X4446MDHWd0mLjk+KfJbc1glQuo0Ft+KIIy POnBY6TDvPcWmTRq/FC9E3xvFeGfVvFfFg/U9/XgROBCe4jm5MFuHkrV6IbnljJKo7Bn jkW3OQ7mnSR/LaF8oIwyKbNnIXsHd2FVqdbw2XZ767UTnl2yjFumPKtfEWsXTfl32+Yz qdjQ== X-Gm-Message-State: AOAM532BIZrPardTSiKBxmTgXpqXOjUeroTkgepeyUpOPydfuJVpbaHH jRG7Z6vBQHb08vKdPd9J1tdWVmcHy3iF/5+EG1h5E/Jgt48xtI3H7Aiuuk/7Xpk4RnacejHSy/N xCiFRXgzQ86mReUgsw1wiKK31WHs= X-Received: by 2002:a37:c441:: with SMTP id h1mr17142606qkm.298.1603119914412; Mon, 19 Oct 2020 08:05:14 -0700 (PDT) X-Received: by 2002:a37:c441:: with SMTP id h1mr17142567qkm.298.1603119914140; Mon, 19 Oct 2020 08:05:14 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id k64sm117193qkc.97.2020.10.19.08.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 08:05:13 -0700 (PDT) From: trix@redhat.com To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, ath9k-devel@qca.qualcomm.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, linuxwifi@intel.com, chunkeey@googlemail.com, pkshih@realtek.com, sara.sharon@intel.com, tova.mussai@intel.com, nathan.errera@intel.com, lior2.cohen@intel.com, john@phrozen.org, shaul.triebitz@intel.com, shahar.s.matityahu@intel.com, Larry.Finger@lwfinger.net, zhengbin13@huawei.com, christophe.jaillet@wanadoo.fr, yanaijie@huawei.com, joe@perches.com, saurav.girepunje@gmail.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Tom Rix Subject: [PATCH] wireless: remove unneeded break Date: Mon, 19 Oct 2020 08:05:07 -0700 Message-Id: <20201019150507.20574-1-trix@redhat.com> X-Mailer: git-send-email 2.18.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Tom Rix A break is not needed if it is preceded by a return or goto Signed-off-by: Tom Rix --- drivers/net/wireless/ath/ath10k/htt_rx.c | 1 - drivers/net/wireless/ath/ath6kl/testmode.c | 1 - drivers/net/wireless/ath/ath9k/hw.c | 1 - drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 2 -- drivers/net/wireless/intersil/p54/eeprom.c | 1 - drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 1 - drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 1 - drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 3 --- 8 files changed, 11 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 5c1af2021883..9c4e6cf2137a 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -3878,7 +3878,6 @@ bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb) return ath10k_htt_rx_proc_rx_frag_ind(htt, &resp->rx_frag_ind, skb); - break; } case HTT_T2H_MSG_TYPE_TEST: break; diff --git a/drivers/net/wireless/ath/ath6kl/testmode.c b/drivers/net/wireless/ath/ath6kl/testmode.c index f3906dbe5495..89c7c4e25169 100644 --- a/drivers/net/wireless/ath/ath6kl/testmode.c +++ b/drivers/net/wireless/ath/ath6kl/testmode.c @@ -94,7 +94,6 @@ int ath6kl_tm_cmd(struct wiphy *wiphy, struct wireless_dev *wdev, return 0; - break; case ATH6KL_TM_CMD_RX_REPORT: default: return -EOPNOTSUPP; diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 6609ce122e6e..b66eeb577272 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c +++ b/drivers/net/wireless/ath/ath9k/hw.c @@ -2308,7 +2308,6 @@ void ath9k_hw_beaconinit(struct ath_hw *ah, u32 next_beacon, u32 beacon_period) ath_dbg(ath9k_hw_common(ah), BEACON, "%s: unsupported opmode: %d\n", __func__, ah->opmode); return; - break; } REG_WRITE(ah, AR_BEACON_PERIOD, beacon_period); diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c index cbdebefb854a..8698ca4d30de 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c @@ -1202,13 +1202,11 @@ static int iwl_mvm_mac_ctx_send(struct iwl_mvm *mvm, struct ieee80211_vif *vif, return iwl_mvm_mac_ctxt_cmd_sta(mvm, vif, action, force_assoc_off, bssid_override); - break; case NL80211_IFTYPE_AP: if (!vif->p2p) return iwl_mvm_mac_ctxt_cmd_ap(mvm, vif, action); else return iwl_mvm_mac_ctxt_cmd_go(mvm, vif, action); - break; case NL80211_IFTYPE_MONITOR: return iwl_mvm_mac_ctxt_cmd_listener(mvm, vif, action); case NL80211_IFTYPE_P2P_DEVICE: diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/net/wireless/intersil/p54/eeprom.c index 5bd35c147e19..3ca9d26df174 100644 --- a/drivers/net/wireless/intersil/p54/eeprom.c +++ b/drivers/net/wireless/intersil/p54/eeprom.c @@ -870,7 +870,6 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len) } else { goto good_eeprom; } - break; default: break; } diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c index 63f9ea21962f..bd9160b166c5 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c @@ -1226,7 +1226,6 @@ static int _rtl88ee_set_media_status(struct ieee80211_hw *hw, default: pr_err("Network type %d not support!\n", type); return 1; - break; } /* MSR_INFRA == Link in infrastructure network; diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c index a36dc6e726d2..f8a1de6e9849 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c @@ -1132,7 +1132,6 @@ static int _rtl8723e_set_media_status(struct ieee80211_hw *hw, default: pr_err("Network type %d not support!\n", type); return 1; - break; } /* MSR_INFRA == Link in infrastructure network; diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c index f41a7643b9c4..225b8cd44f23 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c @@ -2085,12 +2085,10 @@ bool rtl8812ae_phy_config_rf_with_headerfile(struct ieee80211_hw *hw, return __rtl8821ae_phy_config_with_headerfile(hw, radioa_array_table_a, radioa_arraylen_a, _rtl8821ae_config_rf_radio_a); - break; case RF90_PATH_B: return __rtl8821ae_phy_config_with_headerfile(hw, radioa_array_table_b, radioa_arraylen_b, _rtl8821ae_config_rf_radio_b); - break; case RF90_PATH_C: case RF90_PATH_D: pr_err("switch case %#x not processed\n", rfpath); @@ -2116,7 +2114,6 @@ bool rtl8821ae_phy_config_rf_with_headerfile(struct ieee80211_hw *hw, return __rtl8821ae_phy_config_with_headerfile(hw, radioa_array_table, radioa_arraylen, _rtl8821ae_config_rf_radio_a); - break; case RF90_PATH_B: case RF90_PATH_C: -- 2.18.1