Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Subject: Re: [PATCH] ssb: Fix error return in ssb_bus_scan()
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>, m@bues.ch
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201021073305.4400-1-jingxiangfeng@huawei.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <86de3c58-250e-9da7-1446-2e3bef7ea97a@lwfinger.net>
Date:   Wed, 21 Oct 2020 11:47:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201021073305.4400-1-jingxiangfeng@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/21/20 2:33 AM, Jing Xiangfeng wrote:
> Fix to return error code -EINVAL from the error handling case instead
> of 0.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
>   drivers/ssb/scan.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ssb/scan.c b/drivers/ssb/scan.c
> index f49ab1aa2149..4161e5d1f276 100644
> --- a/drivers/ssb/scan.c
> +++ b/drivers/ssb/scan.c
> @@ -325,6 +325,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
>   	if (bus->nr_devices > ARRAY_SIZE(bus->devices)) {
>   		pr_err("More than %d ssb cores found (%d)\n",
>   		       SSB_MAX_NR_CORES, bus->nr_devices);
> +		err = -EINVAL;
>   		goto err_unmap;
>   	}
>   	if (bus->bustype == SSB_BUSTYPE_SSB) {
> 

You misread the code. The current version is returning -ENOMEM, not 0 for this 
error. Returning -EINVAL could be regarded as as better value; however, this 
error is not likely to appear and it does not make much difference!

In any case, the commit message is wrong. NACK.

Larry