Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid>
 <CAD=FV=Xv7Usev=S_ViWPPsa0xL42KDymjEkqJF7S4CzDiuxP3g@mail.gmail.com>
 <CACTWRwtqcMxZKhDR-Q+3CyOw0Ju=iR+ZMg2pVrHEuzbOUebjOg@mail.gmail.com> <001a01d6aa24$6ceaf390$46c0dab0$@codeaurora.org>
In-Reply-To: <001a01d6aa24$6ceaf390$46c0dab0$@codeaurora.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 26 Oct 2020 15:51:13 -0700
Message-ID: <CAD=FV=X5cVdMq9H+cABHmscZvJpswqGZONjqv7FL8kqRNvuHnQ@mail.gmail.com>
Subject: Re: [PATCH] ath10k: add option for chip-id based BDF selection
To:     Rakesh Pillai <pillair@codeaurora.org>
Cc:     Abhishek Kumar <kuabhs@chromium.org>,
        Kalle Valo <kvalo@codeaurora.org>,
        ath10k <ath10k@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Brian Norris <briannorris@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Sat, Oct 24, 2020 at 9:40 AM Rakesh Pillai <pillair@codeaurora.org> wrot=
e:
>
> >         if (bd_ie_type =3D=3D ATH10K_BD_IE_BOARD) {
> > +               /* With variant and chip id */
> >                 ret =3D ath10k_core_create_board_name(ar, boardname,
> > -                                                   sizeof(boardname), =
true);
> > +                                               sizeof(boardname), true=
, true);
>
> Instead of adding a lot of code to generate a second fallback name, its b=
etter to just modify the condition inside the function =E2=80=9Cath10k_core=
_create_board_name=E2=80=9D to allow the generation of BDF tag using chip i=
d, even =E2=80=9Cif ar->id.bdf_ext[0] =3D=3D '\0 =E2=80=9C.
>
> This will make sure that the variant string is NULL, and just board-id an=
d chip-id is used. This will help avoid most of the code changes.
> The code would look as shown below
>
> @@ -1493,7 +1493,7 @@ static int ath10k_core_create_board_name(struct ath=
10k *ar, char *name,
>         }
>
>         if (ar->id.qmi_ids_valid) {
> -               if (with_variant && ar->id.bdf_ext[0] !=3D '\0')
> +               if (with_variant)

Wouldn't the above just be "if (with_chip_id)" instead?  ...but yeah,
that would be a cleaner way to do this.  Abhishek: do you want to post
a v2?

-Doug