Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: pillair=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A4171C43443
From:   "Rakesh Pillai" <pillair@codeaurora.org>
To:     "'Doug Anderson'" <dianders@chromium.org>
Cc:     "'Abhishek Kumar'" <kuabhs@chromium.org>,
        "'Kalle Valo'" <kvalo@codeaurora.org>,
        "'ath10k'" <ath10k@lists.infradead.org>,
        "'LKML'" <linux-kernel@vger.kernel.org>,
        "'linux-wireless'" <linux-wireless@vger.kernel.org>,
        "'Brian Norris'" <briannorris@chromium.org>
References: <20201020000506.1.Ifbc28707942179f1cefc7491e995814564495270@changeid> <CAD=FV=Xv7Usev=S_ViWPPsa0xL42KDymjEkqJF7S4CzDiuxP3g@mail.gmail.com> <CACTWRwtqcMxZKhDR-Q+3CyOw0Ju=iR+ZMg2pVrHEuzbOUebjOg@mail.gmail.com> <001a01d6aa24$6ceaf390$46c0dab0$@codeaurora.org> <CAD=FV=X5cVdMq9H+cABHmscZvJpswqGZONjqv7FL8kqRNvuHnQ@mail.gmail.com> <002801d6ac20$89ac4df0$9d04e9d0$@codeaurora.org> <CAD=FV=W1FiHRHeX-sATY_9x33n6P2n3KaoxfiGjvn2mwAm_-BA@mail.gmail.com>
In-Reply-To: <CAD=FV=W1FiHRHeX-sATY_9x33n6P2n3KaoxfiGjvn2mwAm_-BA@mail.gmail.com>
Subject: RE: [PATCH] ath10k: add option for chip-id based BDF selection
Date:   Tue, 27 Oct 2020 20:41:05 +0530
Message-ID: <002c01d6ac73$67a966e0$36fc34a0$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFjEyTiGf73PRIYZgnn2adypkFjcAJI1HsxAfRirrsAqQquEAGWWD6uAa+Wb7kBxA/hJ6pDPLhw
Content-Language: en-us
Precedence: bulk


> -----Original Message-----
> From: Doug Anderson <dianders@chromium.org>
> Sent: Tuesday, October 27, 2020 8:26 PM
> To: Rakesh Pillai <pillair@codeaurora.org>
> Cc: Abhishek Kumar <kuabhs@chromium.org>; Kalle Valo
> <kvalo@codeaurora.org>; ath10k <ath10k@lists.infradead.org>; LKML
> <linux-kernel@vger.kernel.org>; linux-wireless <linux-
> wireless@vger.kernel.org>; Brian Norris <briannorris@chromium.org>
> Subject: Re: [PATCH] ath10k: add option for chip-id based BDF =
selection
>=20
> Hi,
>=20
> On Mon, Oct 26, 2020 at 10:18 PM Rakesh Pillai =
<pillair@codeaurora.org>
> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Doug Anderson <dianders@chromium.org>
> > > Sent: Tuesday, October 27, 2020 4:21 AM
> > > To: Rakesh Pillai <pillair@codeaurora.org>
> > > Cc: Abhishek Kumar <kuabhs@chromium.org>; Kalle Valo
> > > <kvalo@codeaurora.org>; ath10k <ath10k@lists.infradead.org>; LKML
> > > <linux-kernel@vger.kernel.org>; linux-wireless <linux-
> > > wireless@vger.kernel.org>; Brian Norris <briannorris@chromium.org>
> > > Subject: Re: [PATCH] ath10k: add option for chip-id based BDF =
selection
> > >
> > > Hi,
> > >
> > > On Sat, Oct 24, 2020 at 9:40 AM Rakesh Pillai =
<pillair@codeaurora.org>
> wrote:
> > > >
> > > > >         if (bd_ie_type =3D=3D ATH10K_BD_IE_BOARD) {
> > > > > +               /* With variant and chip id */
> > > > >                 ret =3D ath10k_core_create_board_name(ar, =
boardname,
> > > > > -                                                   =
sizeof(boardname), true);
> > > > > +                                               =
sizeof(boardname), true, true);
> > > >
> > > > Instead of adding a lot of code to generate a second fallback =
name, its
> > > better to just modify the condition inside the function
> > > =E2=80=9Cath10k_core_create_board_name=E2=80=9D to allow the =
generation of BDF tag
> using
> > > chip id, even =E2=80=9Cif ar->id.bdf_ext[0] =3D=3D '\0 =E2=80=9C.
> > > >
> > > > This will make sure that the variant string is NULL, and just =
board-id and
> > > chip-id is used. This will help avoid most of the code changes.
> > > > The code would look as shown below
> > > >
> > > > @@ -1493,7 +1493,7 @@ static int
> ath10k_core_create_board_name(struct
> > > ath10k *ar, char *name,
> > > >         }
> > > >
> > > >         if (ar->id.qmi_ids_valid) {
> > > > -               if (with_variant && ar->id.bdf_ext[0] !=3D '\0')
> > > > +               if (with_variant)
> > >
> > > Wouldn't the above just be "if (with_chip_id)" instead?  ...but =
yeah,
> > > that would be a cleaner way to do this.  Abhishek: do you want to =
post
> > > a v2?
> >
> >
> > The parameter name passed to this function is "with_variant", since =
other
> non-qmi targets (eg QCA6174) use this as a flag to just add the =
variant field.
> > This can be renamed to something meaningful for both qmi and non-qmi
> targets.
>=20
> I think we still need Abhishek's change to have two booleans passed to
> this function, though, right?  Thus, it'll be called 3 times:
>=20
> * with_chip_id =3D false, with_variant =3D false
> * with_chip_id =3D true, with_variant =3D true
> * with_chip_id =3D true, with_variant =3D false
>=20
> The two cases you want to combine are both with "with_chip_id =3D =
true",
> right?  The "with_variant" variable being false will make the variant
> string empty.


I meant that we can use the 4th argument passed to the function " =
ath10k_core_create_board_name" (currently named as with_variant) as an =
indication to use the BDF name with variant.
But even if with_variant=3Dtrue, we allow the variant string to be NULL, =
thereby allowing us to generate a boardname with the format =
"bus=3Dsnoc,qmi-board-id=3D0xab,qmi-chip-id=3D0xcd"

The combinations of args/variant-strings for generating different board =
names will be as follows:
1) with_variant=3Dfalse                                                  =
   :      "bus=3Dsnoc,qmi-board-id=3D0xab"
2) with_variant=3Dtrue, variant_string=3DNULL                :     " =
bus=3Dsnoc,qmi-board-id=3D0xab,qmi-chip-id=3D0xcd"
3) with_variant=3Dtrue, variant_string=3D"variant_xyz"  :     " =
bus=3Dsnoc,qmi-board-id=3D0xab,qmi-chip-id=3D0xcd,variant=3Dvariant_xyz"


This will minimize the code changes.

>=20
> -Doug