Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3455853pxx; Mon, 2 Nov 2020 09:18:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpB1t/23TEYX1W3LPo4Ptyac2n340wBfn+zhQgcCQnigHDMHYKM25CDs84eki8KhIfhKIr X-Received: by 2002:a17:906:f98d:: with SMTP id li13mr10340512ejb.307.1604337519261; Mon, 02 Nov 2020 09:18:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604337519; cv=none; d=google.com; s=arc-20160816; b=L+rrliypNpKWHKQF9R9Flq27zQlVvXepAa0HAjT94FvqjJNlwzr+EDvdRarCpTQZI8 SKAcnbOMaagEZTPpHcIfuj2nku9Rxb+hTkx9KIavIQ4y5FyDtJDsC2Gv6eB748beyeXr MQAxVkGooOh9lRQPapqB4lKgvZl3MI+2bHLvf1K1gnmAmlhQebVXCklfu+wCotHhLl2N K4AttQSG1hS1fk/WMjC3gwfa72KeqLvCFN0ILuxoPIbr3MkqjRJXsBWMrEXATbPHHLcb vdR3pN3ExomOyl18XrRyKdA5MDjRv0QBTH3e2N3zALuPE3EkzuL5/249msjebUGYlbQO uF1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=GK/1Mr2kF0Nc9OODRidv+8GJ+vdyOPdP+l+eWo/8/U0=; b=DJDNbXgMI8upJ0r+QGokMwkEdshnWv2IKHy+Nb27VItLpEnA0FXz4beLAbMroJ7Pn+ ur3enDaY3Bz0B18pCNaEJZfqf8cTKQyl9TT9BQps4xb13Q6XYij8Gev9XADc4C4NXpSG yOMtgDLzjgrAPEKu2avt59tbpIiP36DFnKx5sQPJ7UN6i8ms8l7+cGIBs4kqitlwgGrA WpkksGIvIvY2pHOcjlfFb0K6oMhFFup/PfRPWeWfRtm5tamzD/8vaHGctNHD1hkkQyyF 7hLuvCL/NNke4zrrzeTr4W7Uo2m5cow6E59bHlPMKiylj6JgWoNfw0Xu+HkYxAtSjGDb oHug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="S/VqbvB7"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zn8si11239734ejb.732.2020.11.02.09.18.07; Mon, 02 Nov 2020 09:18:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="S/VqbvB7"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727705AbgKBRPd (ORCPT + 99 others); Mon, 2 Nov 2020 12:15:33 -0500 Received: from z5.mailgun.us ([104.130.96.5]:17191 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbgKBRPd (ORCPT ); Mon, 2 Nov 2020 12:15:33 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604337332; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=GK/1Mr2kF0Nc9OODRidv+8GJ+vdyOPdP+l+eWo/8/U0=; b=S/VqbvB7rMD+dsFV6U/ZIgrqkhlM6sU9Iy3JrFIsnK+NSBsjQq9bQGBQf50a9SOGzKnFvkAb q95hcQknmjwfmmkt76t1kkUgWz5jDLBiud23lFxud60fCv/YEh/8UaXJSWc/u+tp7ckikvGA H4lFFSzR+yHmwsh6JsHcmddPrtc= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5fa03eb493c4278c7237355b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 02 Nov 2020 17:15:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6AED4C433A1; Mon, 2 Nov 2020 17:15:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C038EC433C6; Mon, 2 Nov 2020 17:15:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C038EC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Seung-Woo Kim Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, smoch@web.de, sandals@crustytoothpaste.net, rafal@milecki.pl, digetx@gmail.com, double.lo@cypress.com, amsr@cypress.com, stanley.hsu@cypress.com, saravanan.shanmugham@cypress.com, jean-philippe@linaro.org, frank.kao@cypress.com, netdev@vger.kernel.org, jh80.chung@samsung.com Subject: Re: [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free} References: <1603849967-22817-1-git-send-email-sw0312.kim@samsung.com> Date: Mon, 02 Nov 2020 19:15:23 +0200 In-Reply-To: <1603849967-22817-1-git-send-email-sw0312.kim@samsung.com> (Seung-Woo Kim's message of "Wed, 28 Oct 2020 10:52:47 +0900") Message-ID: <87pn4vof2s.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Seung-Woo Kim writes: > There are missig brcmf_free() for brcmf_alloc(). Fix memory leak > by adding missed brcmf_free(). > > Reported-by: Jaehoon Chung > Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and brcmf_detach() functions") This should be: Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and brcmf_detach() functions") But I can fix that, no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches