Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 52915C433C9
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc:     "Seung-Woo Kim" <sw0312.kim@samsung.com>,
        <franky.lin@broadcom.com>, <hante.meuleman@broadcom.com>,
        <chi-hsien.lin@cypress.com>, <wright.feng@cypress.com>,
        <davem@davemloft.net>, <kuba@kernel.org>,
        <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list.pdl@broadcom.com>,
        <brcm80211-dev-list@cypress.com>, <smoch@web.de>,
        <sandals@crustytoothpaste.net>, <rafal@milecki.pl>,
        <digetx@gmail.com>, <double.lo@cypress.com>, <amsr@cypress.com>,
        <stanley.hsu@cypress.com>, <saravanan.shanmugham@cypress.com>,
        <jean-philippe@linaro.org>, <frank.kao@cypress.com>,
        <netdev@vger.kernel.org>, <jh80.chung@samsung.com>
Subject: Re: [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free}
References: <CGME20201028015033epcas1p4f3d9b38b037ff6d4432e1a2866544e38@epcas1p4.samsung.com>
        <1603849967-22817-1-git-send-email-sw0312.kim@samsung.com>
        <87pn4vof2s.fsf@codeaurora.org>
        <1758a0b5580.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Date:   Mon, 02 Nov 2020 19:46:00 +0200
In-Reply-To: <1758a0b5580.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
        (Arend Van Spriel's message of "Mon, 02 Nov 2020 18:40:00 +0100")
Message-ID: <87h7q7odnr.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Arend Van Spriel <arend.vanspriel@broadcom.com> writes:

> On November 2, 2020 6:15:32 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
>> Seung-Woo Kim <sw0312.kim@samsung.com> writes:
>>
>>> There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
>>> by adding missed brcmf_free().
>>>
>>> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and
>>> brcmf_detach() functions")
>>
>> This should be:
>>
>> Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and
>> brcmf_detach() functions")
>>
>> But I can fix that, no need to resend because of this.
>
> Hi Kalle,
>
> But this is not the commit that needs fixing as I mentioned before.
> Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy
> during PCIe reset") which introduced the actual memory leak.

I'll then change it to:

Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset")

Is that ok?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches