Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1050237pxb; Thu, 5 Nov 2020 22:36:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzDSfw/KpbWTs/rhZKaPOFH0OSJTmMU4aPr1KxLyLCsK/9LWeHI95J/8jRUWGwBqyYWrHIA X-Received: by 2002:a17:906:b53:: with SMTP id v19mr613998ejg.136.1604644605385; Thu, 05 Nov 2020 22:36:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604644605; cv=none; d=google.com; s=arc-20160816; b=dgP1kbDYGN12arLGY8NiSQbJe8+qeBsvn2YMml11IBblUsItKANRIr8tQho1RIp/eF y/ojlicf6PZuPd7cLanyjEp07NwuE7lOtCHNQqNhzotUXsFO/BHa/6hhyxrW0Tbldpti RyeH5rv5xz3UesXiTlz5xLUUNAmWvFbHXu2nfegpRiW1JZbiLKYzLPE8NHxkNiTwI3nD CMXcRwMAilGdI95rlMukAPFyg+nZIZYHTEAyd+y2+rqNrwgU/6eE8omNJSNwmkW6meDR POMZ8eByy+daiyq6jJlNvY0n6DMqrQmw7Ch9TBKEyOcpT9fZROly/GDbyQ3kQ2JX2BnV Btmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:illegal-object:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:sender:dkim-signature; bh=tM5oyoSHdl+1J/pOwaOVdO0e2S4mJz91rpdSkgpqyx0=; b=fDBhr/bjmJdf/Vov8/abb5Q75bW6aXNN8EQ/CftqELkbhCRMiEVa3YGpfxeLRgRzLb qFXXzhM4+eMwuyfJ/t8B1WSZDDF+UC6i05FZcpSV/vRfu5H/gPVpoExy29paVSYGgpDv a04VPxUYVvYrXc+TZZnEsAhg15Tr5pmkv4C7QJ8rUj7Ysi6MciXIoDDrEofLPxbZEJ6D AUZosu8QWMSNftw5+Rb4OENE50sm4kbDs2uiY0i5oRqHbcJePQswr23ZPWqnLx4pJcYi kpTc2X7oxxIgVCS+9mCOX/AycErcVXvJPGoqfKyZUM2rQxSnxU9rLuPv15RGGZlQX7se qC3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=CEzqJ08S; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si274934eda.416.2020.11.05.22.36.06; Thu, 05 Nov 2020 22:36:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=CEzqJ08S; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbgKFGgC (ORCPT + 99 others); Fri, 6 Nov 2020 01:36:02 -0500 Received: from z5.mailgun.us ([104.130.96.5]:15882 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725835AbgKFGgB (ORCPT ); Fri, 6 Nov 2020 01:36:01 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604644561; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=tM5oyoSHdl+1J/pOwaOVdO0e2S4mJz91rpdSkgpqyx0=; b=CEzqJ08SGG8gGfeykWyQyg5R4EJ9CmNApyk22Pflt4Yxn6EcGg/gMO5zPFYCPgOtigd0j+lW 6N/iM0WGWEXTAyzTaD1a4STAwXQj0iBYdnKRlcKeO+FUFSPAxN81PKgnzFoCIQoQVXgiWUBG WQXZQRBdUSk2vEBye6/bR1LhGf0= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fa4eed01baf490ee90e54e7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 06 Nov 2020 06:36:00 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 91670C433FF; Fri, 6 Nov 2020 06:36:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 86CC2C433C8; Fri, 6 Nov 2020 06:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 86CC2C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath10k: sdio: remove redundant check in for loop From: Kalle Valo In-Reply-To: <20200916165748.20927-1-alex.dewar90@gmail.com> References: <20200916165748.20927-1-alex.dewar90@gmail.com> To: Alex Dewar Cc: unlisted-recipients:; (no To-header on input) Alex Dewar , Saeed Mahameed , "David S. Miller" , Jakub Kicinski , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: unlisted-recipients:; (no To-header on input)Alex Dewar ^-missing end of address User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201106063600.91670C433FF@smtp.codeaurora.org> Date: Fri, 6 Nov 2020 06:36:00 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Alex Dewar wrote: > The for loop checks whether cur_section is NULL on every iteration, but > we know it can never be NULL as there is another check towards the > bottom of the loop body. Refactor to avoid this unnecessary check. > > Also, increment the variable i inline for clarity > > Addresses-Coverity: 1496984 ("Null pointer dereferences) > Suggested-by: Saeed Mahameed > Signed-off-by: Alex Dewar > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. dbeb101d28eb ath10k: sdio: remove redundant check in for loop -- https://patchwork.kernel.org/project/linux-wireless/patch/20200916165748.20927-1-alex.dewar90@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches