Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1126911pxb; Fri, 6 Nov 2020 01:27:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJzU2Og1f61u6cUeuP4F8ycWwpFdIj8E5q3aiFEGYVbeufTXSjYHLlm8kPznidLSWazJQC3L X-Received: by 2002:a17:906:3089:: with SMTP id 9mr1142708ejv.535.1604654855247; Fri, 06 Nov 2020 01:27:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604654855; cv=none; d=google.com; s=arc-20160816; b=ejgUagZeGbGY0iDBqwnd/BStchUtgqHO6XyLKFMf/O5DPCE7JEgR3sgTLrssk1exr4 5HNwzr1wSp8znra52pfcL1TSd50X/2Y24zydFF/JMuUJoyfVKMF45L73z3wzfKbCesFN Gs1ouGLXIocDp3wd/ZnG2kyD0NJq0kwWn5nZlpkLsFIg/s8xSIokjTyiWHH0Gkn5deKr eNvkdOIkg4TFqntNaAtDHik1KSZdwjOLB68Jb7ZR2xhQK2o4ZRxUz0IkzQZDL5aN13g8 uhZTuNPK8ATNJmAxN9UZ1iMyIRsTu3tQcQJ8Cp0rTeNoAbZQ02ZpQ5FiTWp5hwhhsZp8 rprw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=pUohgctlXgg+9p83CkZMv9avmRX8LGE1mCsEqpOuJ9Q=; b=G+lyInp0Z8poqzEkYgEssdxeQ4uE9WzPdXFcRJ2Uy00WV6CCI7zMkST9FtbOhsb0Cu 9aAIPEFVShKF57eX1xSVBSyLV9PBqELEZiGzUAYSHncVdLRmF/Kx/zU6gqtdDU3G61jJ S3ks8IqM7n9V88OBsZHs3x1zOfqqkT6vT6/QY0fJSvvako1yn6weeBd1vrH+Sq9ARTLN h1gbzxCFwlv1gKDfaQo3Ui2ywa/TMHfX/2VyzKADbIzmHjkhbUsCwrVSaYrUD1rdDZ4C hLzFw0rAbVzGwsLZ9tsgUhEBUfvrcODNeCz7vI5j+ncLYvVAkw5k4CkGy1nzQETZmBWD g2Jw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si443699ejc.60.2020.11.06.01.27.12; Fri, 06 Nov 2020 01:27:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbgKFJ1A (ORCPT + 99 others); Fri, 6 Nov 2020 04:27:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbgKFJ1A (ORCPT ); Fri, 6 Nov 2020 04:27:00 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0D4AC0613CF for ; Fri, 6 Nov 2020 01:26:59 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kay1K-002CIy-7z; Fri, 06 Nov 2020 10:26:58 +0100 Message-ID: <504b253121f6edd6e3f48072580af3e15c0bc580.camel@sipsolutions.net> Subject: Re: [PATCH V5 1/4] nl80211: add basic multiple bssid support From: Johannes Berg To: John Crispin Cc: linux-wireless@vger.kernel.org, Aloka Dixit Date: Fri, 06 Nov 2020 10:26:57 +0100 In-Reply-To: (sfid-20201106_102443_717492_2C4D7676) References: <20201103091743.1924854-1-john@phrozen.org> <20201103091743.1924854-2-john@phrozen.org> (sfid-20201106_102443_717492_2C4D7676) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2020-11-06 at 10:24 +0100, Johannes Berg wrote: > > and get rid of NL80211_MULTIPLE_BSSID_IES_MAX. Oh, and the fact that this today has a value of 8 _probably_ means you hardcoded the limits of your specific device that you were thinking of now, and we really should have the device advertising the maximum possible value or so? And then I guess we can still hard-code the maximum possible value in cfg80211.h somewhere, use it for array sizes etc., but limit the userspace API to the driver-advertised value (and check in wiphy registration that the cfg80211 limit is >= the driver value). Or is this some fundamental (spec) limit? johannes