Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2074899pxb; Sat, 7 Nov 2020 08:20:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwCiYxbnjz7ZWR6yuT30LbBlchvfERRjLQB5MssKnVchTR+bz0SC2yZ+RMJ8exGIqF/IeXV X-Received: by 2002:aa7:d514:: with SMTP id y20mr7260004edq.384.1604766028605; Sat, 07 Nov 2020 08:20:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604766028; cv=none; d=google.com; s=arc-20160816; b=SYofTBjQJR6W32jLVRlvRZn3+F81l9trgAZJW8cOKGxplqUuGht3yVX8hjLK+1SEZK Uknz2LyexBfeB70RxkN9KiiRGQo/DY0hi4VGITkWES2us8D6Hv5klmfkrxMDlaNZPkyJ fDWv8cyQj87DpRCyfLXUYGTnvv5LhGzEc3EeStn9FE6PsNjxuWEOQ0OwVwYlaMlPzZQp nmUespzio9xsbj1w42SgDKGAALOk9la4/vko6nznF/pIHOQjgF91exwMaSXus1NkP9ev EaHIB4UhduEOsTforYsbkjatGoqUlFWPIjP7YxIzhgl3Jv8M7zPzwR2L5JAmzZkK6IU9 pa2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=NnQ6UNO+8umQ59Id60TVdkDgcWPo+xFIoMKHjZf9InY=; b=s84QV5KLuwcJRKYMGjR4WJmXLaPKFq9phgKJ1GNYTr/gaKxUDJJwJ2UCyOfBSiyE1n EgAON5RcIqw1pir8M7LuBZmb+PkbHNP/1nV4rmufooORcNnMpZoaNvwGaYiIMNm22w8O LXl4CNqW76Wova/ZrMhT5AOwXa5+lLqNYSSNo1XyJeKRH048jZgA3SnyP7OzDxpLXAqW oI3KGMqg6HBMDEHEZ+3nzOWF0VE2YA1pC+/1w0Aft/5o6KM0dOECuNF3YhWuqa1Ycf4F UXPwwV/XoGT2kgNdQc/UP1GPgjDRVfRfXw8WE7u/DLHwOV1d1A2910QGkuch8FpwRyhy tmaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=WpUsXIIZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si3457991edy.201.2020.11.07.08.20.04; Sat, 07 Nov 2020 08:20:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=WpUsXIIZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728410AbgKGQTx (ORCPT + 99 others); Sat, 7 Nov 2020 11:19:53 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:29497 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728232AbgKGQTw (ORCPT ); Sat, 7 Nov 2020 11:19:52 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604765992; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=NnQ6UNO+8umQ59Id60TVdkDgcWPo+xFIoMKHjZf9InY=; b=WpUsXIIZoRfebsT9uVTrln/9p6edvvBNgYMwTxKtxXsLmxECO3SenyeRIk+7yD0cIzFqcjab L68pPuEab6g4Xlj5QHWyY0ujeE+uI3wfSxxL2sm+hkvBx8MMgl6W9gff6zmhzs3jgjdPGZqb VlM1nrevYK91m5ZwxN4VhUF6qQI= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5fa6c927c1b74298b70a68bf (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 07 Nov 2020 16:19:51 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7B88EC43387; Sat, 7 Nov 2020 16:19:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D5FC3C433C6; Sat, 7 Nov 2020 16:19:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D5FC3C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free} From: Kalle Valo In-Reply-To: <1603849967-22817-1-git-send-email-sw0312.kim@samsung.com> References: <1603849967-22817-1-git-send-email-sw0312.kim@samsung.com> To: Seung-Woo Kim Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, smoch@web.de, sandals@crustytoothpaste.net, rafal@milecki.pl, digetx@gmail.com, double.lo@cypress.com, amsr@cypress.com, stanley.hsu@cypress.com, saravanan.shanmugham@cypress.com, jean-philippe@linaro.org, frank.kao@cypress.com, netdev@vger.kernel.org, sw0312.kim@samsung.com, jh80.chung@samsung.com User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201107161950.7B88EC43387@smtp.codeaurora.org> Date: Sat, 7 Nov 2020 16:19:50 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Seung-Woo Kim wrote: > There are missig brcmf_free() for brcmf_alloc(). Fix memory leak > by adding missed brcmf_free(). > > Reported-by: Jaehoon Chung > Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset") > Signed-off-by: Seung-Woo Kim > Reviewed-by: Arend van Spriel Patch applied to wireless-drivers-next.git, thanks. 9db946284e07 brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free} -- https://patchwork.kernel.org/project/linux-wireless/patch/1603849967-22817-1-git-send-email-sw0312.kim@samsung.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches