Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2115790pxb; Sat, 7 Nov 2020 09:42:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZtjDM5KkZvlxOENHQCGTjaH8DeTk/nSEr7/OEYwGclArL7Z0ZbR3t0eZiwy1CwR8f/Zey X-Received: by 2002:a17:906:fa1b:: with SMTP id lo27mr7540527ejb.216.1604770942570; Sat, 07 Nov 2020 09:42:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604770942; cv=none; d=google.com; s=arc-20160816; b=RqjuH6XWNZco1JcyOVJi8meiu0xbFGH7xBjkt2P7XUOTK1LS5Hv9TTz+1yo2hds6iK /gGf1rCoJ3TarOD4jeGLKa5duA3bV0XOOxowA5HiOSBluSKA5kDob8e2rcZ01/RPwCNQ eKBOk8NDFKYyST/DBl7iRDWKUWiIaJUGN3esA/Ri4rXT9EfbuWVlToqY2UPMv2IdSAq1 Xk+WyWm8HOCT5go2vHlYEzZCbkW1Q009/WhqD8GmBJlgwmL3QLrAuqr3JuYLNykiKFt8 qPqtQGFjTODHLbaxFaVWeukcZ+gLfuULUh/FHmtRfEWFE17UGbSKnUyH8mT4mnlIlD22 G/vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:subject:user-agent:references :in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=GqKyCwNNCAlVqCKmAz8aMMvXlo7Mp2TspyGVx22UUc4=; b=kB8q231+px900+WgRUSp7Qbtx0gXxdSENdlXtVJxd3JhHhSCSaSZbnrDsV0qIAubN9 xUQP1z9QTVQ3x37AkxnVt9Ji/WiweDTTgiq23IV5wkWGTfdDw4GUvRi4EB3h8JCEU/Wz P2inu48NlcHmJRpB135TAWNXX7JQyhBsBEd4BnxQpSTq36smbP8NSfNpU/JOK13Syd04 D2jcu6Pr30lU3OeC6lDg63ky323G8ubPGY6v4xzTvnU7nvX/0Sdedzze3hXk3efVTfPF uANkETloUW7aLPKQ4w8cVeERj9qne1xixl8NbMerg772HJZV+3pMYwA8TRNnVs5BSfPP /yAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=SeGR+roY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m22si3722208edq.478.2020.11.07.09.41.52; Sat, 07 Nov 2020 09:42:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=SeGR+roY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbgKGRlL (ORCPT + 99 others); Sat, 7 Nov 2020 12:41:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbgKGRlL (ORCPT ); Sat, 7 Nov 2020 12:41:11 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C583EC0613D4 for ; Sat, 7 Nov 2020 09:41:10 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id s25so6431409ejy.6 for ; Sat, 07 Nov 2020 09:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version; bh=GqKyCwNNCAlVqCKmAz8aMMvXlo7Mp2TspyGVx22UUc4=; b=SeGR+roY6sK7+VgRCw4MrCx/S8cqkU+mbf/Nu8V82JT8cSrUemAYBvXj7hOvSDe68M wggRwza8yGV4jywo5NQQHr/5wmTpJN3e/pqxJU2w0M6+EPs7NY7oeHCo8d8PfOC8p9Ac Pj9o9rByyPsx12oekN7Y3v0zrRFTLZMBnyy3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version; bh=GqKyCwNNCAlVqCKmAz8aMMvXlo7Mp2TspyGVx22UUc4=; b=f/tShXRHnmuooo4VR3ONauMCzyG3d6fa+j7CUtSjsZEuqsNRqYhyUHLLS1GOHymSSO ebh5au3WWHnHhK2SrcylPh12sHZUTB0jTq2TPQyCnL/x9+cVcjOKgElpWU5FHFRQOKMO fFrUNsRb1X8D1m3OcVyyaT8QZN/sMLr7EMZswEHe7AJaf+zljjxb4Q8W83//nytUX9ku q5rTFIKlhXUayHkaYwvFxQC0hGbC0+a3a+1Yx+1M0LxwQSAuXJ09S/HJlJjX4t68gxCT LWefzoEhM8JHPcAYfg99JHS/trNbgPXZp0bfJalbS6SRR6+m3tAimrlQ0YoEsRF6mk7L 89Xg== X-Gm-Message-State: AOAM533jZkCBB71GZE22yoZQA5uIxsYDuUtp2g2hzyqVNKqm9FXJrtqP cL+YdMIxtgdqEKge6NA+1cK2Xw== X-Received: by 2002:a17:906:57cc:: with SMTP id u12mr7789863ejr.163.1604770869001; Sat, 07 Nov 2020 09:41:09 -0800 (PST) Received: from [192.168.178.38] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id a10sm3826517edn.77.2020.11.07.09.41.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2020 09:41:08 -0800 (PST) From: Arend Van Spriel To: Taehee Yoo , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Date: Sat, 07 Nov 2020 18:41:07 +0100 Message-ID: <175a3cc2738.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20201107172152.828-18-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> <20201107172152.828-18-ap420073@gmail.com> User-Agent: AquaMail/1.27.0-1705 (build: 102700004) Subject: Re: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000009f6a9705b387d559" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --0000000000009f6a9705b387d559 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On November 7, 2020 6:25:15 PM Taehee Yoo wrote: > If THIS_MODULE is not set, the module would be removed while debugfs is > being used. > It eventually makes kernel panic. Is this really a valid concern in the context of debugs? I tend to say it is not. Whenever I am using debugs to debug my driver I make sure to avoid removing it. Regards, Arend --0000000000009f6a9705b387d559 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQTAYJKoZIhvcNAQcCoIIQPTCCEDkCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg2hMIIE6DCCA9CgAwIBAgIOSBtqCRO9gCTKXSLwFPMwDQYJKoZIhvcNAQELBQAwTDEgMB4GA1UE CxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMT Ckdsb2JhbFNpZ24wHhcNMTYwNjE1MDAwMDAwWhcNMjQwNjE1MDAwMDAwWjBdMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTEzMDEGA1UEAxMqR2xvYmFsU2lnbiBQZXJzb25h bFNpZ24gMiBDQSAtIFNIQTI1NiAtIEczMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA tpZok2X9LAHsYqMNVL+Ly6RDkaKar7GD8rVtb9nw6tzPFnvXGeOEA4X5xh9wjx9sScVpGR5wkTg1 fgJIXTlrGESmaqXIdPRd9YQ+Yx9xRIIIPu3Jp/bpbiZBKYDJSbr/2Xago7sb9nnfSyjTSnucUcIP ZVChn6hKneVGBI2DT9yyyD3PmCEJmEzA8Y96qT83JmVH2GaPSSbCw0C+Zj1s/zqtKUbwE5zh8uuZ p4vC019QbaIOb8cGlzgvTqGORwK0gwDYpOO6QQdg5d03WvIHwTunnJdoLrfvqUg2vOlpqJmqR+nH 9lHS+bEstsVJtZieU1Pa+3LzfA/4cT7XA/pnwwIDAQABo4IBtTCCAbEwDgYDVR0PAQH/BAQDAgEG MGoGA1UdJQRjMGEGCCsGAQUFBwMCBggrBgEFBQcDBAYIKwYBBQUHAwkGCisGAQQBgjcUAgIGCisG AQQBgjcKAwQGCSsGAQQBgjcVBgYKKwYBBAGCNwoDDAYIKwYBBQUHAwcGCCsGAQUFBwMRMBIGA1Ud EwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFGlygmIxZ5VEhXeRgMQENkmdewthMB8GA1UdIwQYMBaA FI/wS3+oLkUkrk1Q+mOai97i3Ru8MD4GCCsGAQUFBwEBBDIwMDAuBggrBgEFBQcwAYYiaHR0cDov L29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3RyMzA2BgNVHR8ELzAtMCugKaAnhiVodHRwOi8vY3Js Lmdsb2JhbHNpZ24uY29tL3Jvb3QtcjMuY3JsMGcGA1UdIARgMF4wCwYJKwYBBAGgMgEoMAwGCisG AQQBoDIBKAowQQYJKwYBBAGgMgFfMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2JhbHNp Z24uY29tL3JlcG9zaXRvcnkvMA0GCSqGSIb3DQEBCwUAA4IBAQConc0yzHxn4gtQ16VccKNm4iXv 6rS2UzBuhxI3XDPiwihW45O9RZXzWNgVcUzz5IKJFL7+pcxHvesGVII+5r++9eqI9XnEKCILjHr2 DgvjKq5Jmg6bwifybLYbVUoBthnhaFB0WLwSRRhPrt5eGxMw51UmNICi/hSKBKsHhGFSEaJQALZy 4HL0EWduE6ILYAjX6BSXRDtHFeUPddb46f5Hf5rzITGLsn9BIpoOVrgS878O4JnfUWQi29yBfn75 HajifFvPC+uqn+rcVnvrpLgsLOYG/64kWX/FRH8+mhVe+mcSX3xsUpcxK9q9vLTVtroU/yJUmEC4 OcH5dQsbHBqjMIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAwTDEgMB4G A1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNV BAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4MTAwMDAwWjBMMSAwHgYDVQQL ExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UEAxMK R2xvYmFsU2lnbjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5BngiFvXAg7aE yiie/QV2EcWtiHL8RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X17YUhhB5 uzsTgHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmmKPZpO/bL yCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zdQQ4gOsC0p6Hpsk+QLjJg 6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZXriX7613t2Saer9fwRPvm2L7DWzgVGkW qQPabumDk3F2xmmFghcCAwEAAaNCMEAwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8w HQYDVR0OBBYEFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBLQNvAUKr+ yAzv95ZURUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25sbwMpjjM5 RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK6fBdRoyV3XpYKBov Hd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQXmcIfeg7jLQitChws/zyrVQ4PkX42 68NXSb7hLi18YIvDQVETI53O9zJrlAGomecsMx86OyXShkDOOyyGeMlhLxS67ttVb9+E7gUJTb0o 2HLO02JQZR7rkpeDMdmztcpHWD9fMIIFTjCCBDagAwIBAgIMUd5uz4+i70IloyctMA0GCSqGSIb3 DQEBCwUAMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQD EypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0gRzMwHhcNMjAwOTA0MDc1 NDIyWhcNMjIwOTA1MDc1NDIyWjCBlTELMAkGA1UEBhMCSU4xEjAQBgNVBAgTCUthcm5hdGFrYTES MBAGA1UEBxMJQmFuZ2Fsb3JlMRYwFAYDVQQKEw1Ccm9hZGNvbSBJbmMuMRkwFwYDVQQDExBBcmVu ZCBWYW4gU3ByaWVsMSswKQYJKoZIhvcNAQkBFhxhcmVuZC52YW5zcHJpZWxAYnJvYWRjb20uY29t MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAqJ64ukMVTPoACllUoR4YapHXMtf3JP4e MniQLw3G3qPYDcmuupakle+cqBUzxXOu9odSBxw7Ww4qooIVjDOuA1VxtYzieKLPmZ0sgvy1RhVR obr58d7/2azKP6wecAiglkT6jZ0by1TbLhuXNFByGxm7iF1Hh/sF3nWKCHMxBtEFrmaKhM1MwCDS j5+GBWrrZ/SNgVS+XqjaQyRg/h3WB95FxduXpYq5p0kWPJZhV4QeyMGSIRzqPwLbKdqIlRhkGxds pra5sIx/TR6gNtLG9MpND9zQt5j42hInkP81vqu9DG8lovoPMuR0JVpFRbPjHZ07cLqqbFMVS/8z 53iSewIDAQABo4IB0zCCAc8wDgYDVR0PAQH/BAQDAgWgMIGeBggrBgEFBQcBAQSBkTCBjjBNBggr BgEFBQcwAoZBaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NwZXJzb25hbHNp Z24yc2hhMmczb2NzcC5jcnQwPQYIKwYBBQUHMAGGMWh0dHA6Ly9vY3NwMi5nbG9iYWxzaWduLmNv bS9nc3BlcnNvbmFsc2lnbjJzaGEyZzMwTQYDVR0gBEYwRDBCBgorBgEEAaAyASgKMDQwMgYIKwYB BQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAkGA1UdEwQCMAAw RAYDVR0fBD0wOzA5oDegNYYzaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9nc3BlcnNvbmFsc2ln bjJzaGEyZzMuY3JsMCcGA1UdEQQgMB6BHGFyZW5kLnZhbnNwcmllbEBicm9hZGNvbS5jb20wEwYD VR0lBAwwCgYIKwYBBQUHAwQwHwYDVR0jBBgwFoAUaXKCYjFnlUSFd5GAxAQ2SZ17C2EwHQYDVR0O BBYEFHAaaA+cRo3vYiA6aKVu1bOs4YAYMA0GCSqGSIb3DQEBCwUAA4IBAQCYLdyC8SuyQV6oa5uH kGtqz9FCJC/9gSclQLM8dZLHF3FYX8LlcQg/3Ct5I29YLK3T/r35B2zGljtXqVOIeSEz7sDXfGNy 3dnLIafB1y04e7aR+thVn5Rp1YTF01FUWYbZrixlVuKvjn8vtKC+HhAoDCxvqnqEuA/8Usn7B0/N uOA46oQTLe3kjdIgXWJ29JWVqFUavYdcK0+0zyfeMBCTO6heYABeMP3wzYHfcuFDhqldTCpumqhZ WwHVQUbAn+xLMIQpycIQFoJIGJX4MeaTSMfLNP2w7nP2uLNgIeleF284vS0XVkBXSCgIGylP4SN+ HQYrv7fVCbtp+c7nFvP7MYICbzCCAmsCAQEwbTBdMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQR2xv YmFsU2lnbiBudi1zYTEzMDEGA1UEAxMqR2xvYmFsU2lnbiBQZXJzb25hbFNpZ24gMiBDQSAtIFNI QTI1NiAtIEczAgxR3m7Pj6LvQiWjJy0wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIE II6JHUbkEtguPaalgdWY0fGFyx7fPz6w+pxmBTBUSVgtMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0B BwEwHAYJKoZIhvcNAQkFMQ8XDTIwMTEwNzE3NDEwOVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgB ZQMEASowCwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQow CwYJKoZIhvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAbWb7+qoWRifzBfakC SmnIgmP8Z1+V+kH1UxWZMv+i5S7d3VdQm3EXvlojysdC+nF4//ECr3KaR6mXurjZ6UfpUzP/S/L4 VWDyeywrfF54ZcaIasjCbNYCl4Ydoeqje7EN/ozeoJxj3vO2VrNp0ipfeBK1sHJLpaZ06qZENHy3 SuoS7h8+serEeE41NcxpkwGv1vRBoPM/6uQEzyvWufZXolVpSTDw3q1hImXJPoklQMl0qpW9s273 YXfve+WY4N921glGiO9lfo3ekQil3q1mVRbRCC2jUjXga0Te1z5GBcXDPly1poraGbpmuZASuF0Z 3oVAZmSRmWg5azN/kre1 --0000000000009f6a9705b387d559--