Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: mvLqvLW5yf4lkfE5qnpZKFk9qBaw91x2xyL1GGgrB96H3PH58HpFKUIv8uhhYQTwhYO6L/rko2
 PAu73Id9S2Nw==
From:   <Chi-Hsien.Lin@infineon.com>
To:     <zhangchangzhong@huawei.com>, <arend.vanspriel@broadcom.com>,
        <franky.lin@broadcom.com>, <hante.meuleman@broadcom.com>,
        <Wright.Feng@infineon.com>, <kvalo@codeaurora.org>,
        <davem@davemloft.net>, <kuba@kernel.org>,
        <Chung-Hsien.Hsu@infineon.com>
CC:     <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list.pdl@broadcom.com>,
        <brcm80211-dev-list@cypress.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] brcmfmac: fix error return code in
 brcmf_cfg80211_connect()
Thread-Topic: [PATCH] brcmfmac: fix error return code in
 brcmf_cfg80211_connect()
Thread-Index: AQHWuYX2LsrVIVcLDEeEhdSUn8X2dKnFvg+Q
Date:   Fri, 13 Nov 2020 08:45:50 +0000
Message-ID: <ea4b55d801ed418f9b0430ddba559457@infineon.com>
References: <1605248896-16812-1-git-send-email-zhangchangzhong@huawei.com>
In-Reply-To: <1605248896-16812-1-git-send-email-zhangchangzhong@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

> Fix to return a negative error code from the error handling case instead =
of 0, as done elsewhere in th>
>
> Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offloa=
d")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@infineon.com>

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c =
b/drivers/net/wireless/broadc>
> index a2dbbb9..0ee421f 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct =
net_device *ndev,
>               BRCMF_WSEC_MAX_PSK_LEN);
>     else if (profile->use_fwsup =3D=3D BRCMF_PROFILE_FWSUP_SAE) {
>       /* clean up user-space RSNE */
> -             if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
> +             err =3D brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
> +             if (err) {
>                       bphy_err(drvr, "failed to clean up user-space RSNE\=
n");
>                       goto done;
> }
> --
> 2.9.5