Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1004106pxb; Fri, 13 Nov 2020 01:23:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyOFLfPmA+xIzUAfDfCf0qizRm8LusV3UuvGxc869952YpPNyxhaSwxLxUVpr79rxaZl2SH X-Received: by 2002:a17:906:2582:: with SMTP id m2mr1026177ejb.172.1605259430554; Fri, 13 Nov 2020 01:23:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605259430; cv=none; d=google.com; s=arc-20160816; b=GeMLNxDXevhKxW3e+2haPQEOWWPtQg05i9g/naFgN4uf5C6H3VLXccf2UKgdwOZj+j kQmYN/dRvBcJTjnEcNKallAK0BtUbGS6r2ExaKxUx+8XvgyQ89O9n36nxepriZ47PZHL xR5aNTI9pF/jFBa1Ej/lfWRT1R/jpF7ac4LNSSdmcz7zOcKozKZHz+VZITlkeQf7jfRR MFq8PeZRtH3EHEy9uAQBkSv3w0UAc8Z7Lf1jRiO5hhxdoj/DRW1yt5foja9IUWfXDzU1 VEcuFjVFjl+Yv6vgJfoCs/8hu+61StfIhniEAK5LCzL/Ui7sX9s+rFySSDnZQtYSGFqA EKuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=4PVBm/6yQPIfadOanWxlLyiPRb74j6wT3frpZm8OQq4=; b=rZ2r0FlJylEXfR+WmMw3S+6kxTvxkZYYB9LKtzJhsQ8rjCap7zVCupSg9hQSc9pslO 6kXU0AE5FwV0+50syCIbqDtkloUMl/LzTFHxyzqTnA51h1HNvr9GrntMUQNpfFgc27X6 5pWb8WtAkXJNLVStkOcWMpgMthhzfu87sdk8ofFKjRff8XNc1Dz9rh13zfKNdEhk18kJ oOrI6g5QNs3zO0vdaodSQX1nD1rMU97E4HUrgTFqT55U9KjIdEvHMKsDaLSM9mUWBB/L DPTHTxBeeAfAkM/C225fMjFg+hgbcJoLnnS7oje3XyRoHAcU7WABULQKCS+Ps+fMrxEc nQRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si3222533ejb.367.2020.11.13.01.23.25; Fri, 13 Nov 2020 01:23:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgKMJXM (ORCPT + 99 others); Fri, 13 Nov 2020 04:23:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgKMJXM (ORCPT ); Fri, 13 Nov 2020 04:23:12 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B890C0613D1; Fri, 13 Nov 2020 01:23:12 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kdVIR-006rOM-33; Fri, 13 Nov 2020 10:23:07 +0100 Message-ID: <820f10c46841ac79c78d5952ebbc816fd710b4fd.camel@sipsolutions.net> Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable From: Johannes Berg To: Wen Gong Cc: Arend Van Spriel , linux-wireless@vger.kernel.org, kirtika@google.com, linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org Date: Fri, 13 Nov 2020 10:23:05 +0100 In-Reply-To: References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> <83dd20def685d303106f285400367b6e@codeaurora.org> <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> <30e2e578983e4df447e0c26c5bba0aba@codeaurora.org> <0e60e4cdc036a5ef7394848d212a6e3f499c386f.camel@sipsolutions.net> <256c487bb8c8c191a88d806e6125296e@codeaurora.org> <365b1abcfd043a3b0c356ec9f8c7c44acd5a79d2.camel@sipsolutions.net> <6caaa87ba3f37bd424e92d03c2340689@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > > Yes but you have to iterate all the stations and check they belong to > > the interface and all that I think? > > > Maybe not need. > if NL80211_IFTYPE_STATION and NON-WLAN_STA_TDLS_PEER, it has only 1 > station for the ieee80211_vif > by my understand. Well, yes, but there's no counter. So you need to iterate to see if there are any additional TDLS peers (in addition to the STA entry for the AP). johannes