Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 22EABC433C6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Pkshih <pkshih@realtek.com>
Cc:     Tony Chuang <yhchuang@realtek.com>,
        "xiakaixu1987\@gmail.com" <xiakaixu1987@gmail.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kaixuxia\@tencent.com" <kaixuxia@tencent.com>
Subject: Re: [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set_tdma
References: <1605367343-11770-1-git-send-email-kaixuxia@tencent.com>
        <1605600696.20048.11.camel@realtek.com>
Date:   Tue, 17 Nov 2020 10:21:37 +0200
In-Reply-To: <1605600696.20048.11.camel@realtek.com> (pkshih@realtek.com's
        message of "Tue, 17 Nov 2020 08:12:40 +0000")
Message-ID: <87ft58z94e.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Pkshih <pkshih@realtek.com> writes:

> On Sat, 2020-11-14 at 15:22 +0000, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>=20
>> The value of the bool variable ap_enable is always false, so the first
>> if branch is unreached code. Remove it.
>>=20
>> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
>> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
>> ---
>> =C2=A0drivers/net/wireless/realtek/rtw88/coex.c | 12 +-----------
>> =C2=A01 file changed, 1 insertion(+), 11 deletions(-)
>>=20
>> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c
>> b/drivers/net/wireless/realtek/rtw88/coex.c
>> index aa08fd7d9fcd..9c7963e45755 100644
>> --- a/drivers/net/wireless/realtek/rtw88/coex.c
>> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
>> @@ -863,18 +863,8 @@ static void rtw_coex_set_tdma(struct rtw_dev *rtwde=
v, u8
>> byte1, u8 byte2,
>> =C2=A0	struct rtw_coex_dm *coex_dm =3D &coex->dm;
>> =C2=A0	struct rtw_chip_info *chip =3D rtwdev->chip;
>> =C2=A0	u8 ps_type =3D COEX_PS_WIFI_NATIVE;
>> -	bool ap_enable =3D false;
>
> The variable 'ap_enable' is used to indicate a vif is running in AP mode.
> At the first coex version, rtw88 doesn't support AP mode yet, so ap_enable
> is set to false. For now, AP mode is ready, and I can send a patch to set
> proper value depends on vif mode.
>
> Since I'm submitting coex patches to upgrade the code. In order to avoid
> conflicting, I'll send the patch to set proper ap_enable after all my pat=
ches
> are merged.

Ok, I'll then drop this.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes