Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: hmddJNtHN+pJbdV4e4OrvMkOpA/CTKTuD4cFizoqQPupNvj3LuTp17fVwnxOn0TLntpz55rI/B
 L9Nwhm0XMIr+EW4ix70lNGAgJPgiDqY2Y0NiJ5CPZRDHRxL/TSR7p2yAsng0PMeM/jJToY0sqL
 JWfV7gZMGefbKbZRuJva6KyoxKutlD70vpyuWtVfCvyr3wC4OCPmjx1DuL4KN583S+E6TFqcSz
 lQFA1oKiTm35oCNm7bQqtQ8p5f+dlrdorjuGIVtZTlMvcw7ndIbsAq7V0/hr05k/MdRER8NWz4
 5h0=
From:   <Ajay.Kathat@microchip.com>
To:     <linux-wireless@vger.kernel.org>, <kvalo@codeaurora.org>
CC:     <Claudiu.Beznea@microchip.com>, <Sripad.Balwadgi@microchip.com>,
        <Ajay.Kathat@microchip.com>
Subject: [PATCH 3/5] wilc1000: free resource in wilc_wlan_txq_add_mgmt_pkt()
 for failure path
Thread-Topic: [PATCH 3/5] wilc1000: free resource in
 wilc_wlan_txq_add_mgmt_pkt() for failure path
Thread-Index: AQHWwx/ef/9yBNwo30Wr1rzW7nXWOg==
Date:   Wed, 25 Nov 2020 11:41:09 +0000
Message-ID: <20201125114059.10006-4-ajay.kathat@microchip.com>
References: <20201125114059.10006-1-ajay.kathat@microchip.com>
In-Reply-To: <20201125114059.10006-1-ajay.kathat@microchip.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e03ea29a-2c35-4185-d934-08d8913700da
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2020 11:41:09.5057
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Cc7O+cwDu2u/DsozGjuX//YlDfhoS3nQPvWXhLe9DXJViiTUfyv6HLgxVOngYek4uc2A646DYw5QShh0xzcVzNOMIFoFJ3inBh75OLepj4Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1287
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Ajay Singh <ajay.kathat@microchip.com>

Before returing from wilc_wlan_txq_add_mgmt_pkt() invoke tx_complete_fn()
callback to free up allocated memory for failure case.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/net/wireless/microchip/wilc1000/wlan.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/w=
ireless/microchip/wilc1000/wlan.c
index f0cc2da7c9c7..42b5db4e2d81 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -319,13 +319,17 @@ int wilc_wlan_txq_add_mgmt_pkt(struct net_device *dev=
, void *priv, u8 *buffer,
=20
 	wilc =3D vif->wilc;
=20
-	if (wilc->quit)
+	if (wilc->quit) {
+		tx_complete_fn(priv, 0);
 		return 0;
+	}
=20
 	tqe =3D kmalloc(sizeof(*tqe), GFP_ATOMIC);
=20
-	if (!tqe)
+	if (!tqe) {
+		tx_complete_fn(priv, 0);
 		return 0;
+	}
 	tqe->type =3D WILC_MGMT_PKT;
 	tqe->buffer =3D buffer;
 	tqe->buffer_size =3D buffer_size;
--=20
2.24.0