Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp659684pxu; Thu, 26 Nov 2020 08:20:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYvPAteJOAnu55DLwJJsASCFPLJCVf3FPot7oJ10bhCEyoey/TEomjzHlbprEdus8EbZR6 X-Received: by 2002:aa7:d607:: with SMTP id c7mr3260684edr.70.1606407608567; Thu, 26 Nov 2020 08:20:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606407608; cv=none; d=google.com; s=arc-20160816; b=ghzc8Bg8NdTUrDm4H9YOnqCDUIIUVIZTjo0vdPZHI4NNqm90Xajl2rDw+FE+nyYZdW RoH5o/2j1Ss1pld5EkS/Q6sKZh2+Swa30iEA1v6cHFl2HzItY8UL6g2q0vFwK/2EvvJo xX+Tc0uD+VWsT3P7Eo4PbD+UnWgnxzYhQt8hHByi5itxpapCgoev6Kh+pW9OhQPSFOtN yuCUdFu/1+lCWLm9o2AcFKtnCUQvLfJ1yYCllPbmQVr6kmZ9oG4Rag3bYz+0QTSuI7OE ZwQo5FgAoGW7YtZ0mAgMp45d2c6UNvafuZQ614qC8qttgEpE63BjnexNsQRRS9uJLCbW K9jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=C/pKkkn3g0Oj3EE85AEaWdLWORIVZF73S0sG1A+NrZk=; b=yQ3cHU/HcQQMGW0pgUhkk/M14gXlVtFKAVi28Ljlt4fnJmna7wu3/h1zX6Gi1FNNGC n+BdTGnJFpewsIXfctderhI+Hn4k2iFZmRl4eQsuwDvjQ1ajsNtsFrfeXHMJtP57FEWV 8l2CC8xO7BR6zgXDMBOe7gv3eNLfcTadmBRgN9WdkQD14spi/pFGIPx602NVN7rtFBU6 tnEr8gGa0hj9fyy/9xe/zqpzQ/kCK9dNm1XtH8rHEr96xvZS4/2fM3Ih4ujaUWKSYQpK /1d4Fpzn0exSPF2MKVjidQf0YZ1jiPakaJdHB4QAOob32x70wE2sxhJUxpBa2qbnfL0x 2s7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si3254581ejx.607.2020.11.26.08.19.35; Thu, 26 Nov 2020 08:20:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391506AbgKZQRV (ORCPT + 99 others); Thu, 26 Nov 2020 11:17:21 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:11290 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730181AbgKZQRV (ORCPT ); Thu, 26 Nov 2020 11:17:21 -0500 Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 26 Nov 2020 08:17:21 -0800 X-QCInternal: smtphost Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/AES256-SHA; 26 Nov 2020 08:17:19 -0800 X-QCInternal: smtphost Received: from youghand-linux.qualcomm.com ([10.206.66.115]) by ironmsg01-blr.qualcomm.com with ESMTP; 26 Nov 2020 21:47:02 +0530 Received: by youghand-linux.qualcomm.com (Postfix, from userid 2370257) id 5F17521B5F; Thu, 26 Nov 2020 21:47:01 +0530 (IST) From: Youghandhar Chintala To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, pillair@codeaurora.org, dianders@chromium.org, kuabhs@chromium.org, briannorris@chromium.org, Youghandhar Chintala Subject: [PATCH] ath10k: skip the wait for completion to recovery in shutdown path Date: Thu, 26 Nov 2020 21:46:56 +0530 Message-Id: <20201126161656.18802-1-youghand@codeaurora.org> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Currently in the shutdown callback we wait for recovery to complete before freeing up the resources. This can lead to unwanted delay during the shutdown and thereby increase the shutdown time. As an attempt to take less time during shutdown, remove the wait for recovery completion in the shutdown callback. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Youghandhar Chintala Change-Id: I0474ab7dc3730aaacac888bb9a7acc2fa0e8b4f8 --- drivers/net/wireless/ath/ath10k/snoc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 84666f72bdfa..15580a91fe98 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1790,9 +1790,6 @@ static int ath10k_snoc_remove(struct platform_device *pdev) reinit_completion(&ar->driver_recovery); - if (test_bit(ATH10K_SNOC_FLAG_RECOVERY, &ar_snoc->flags)) - wait_for_completion_timeout(&ar->driver_recovery, 3 * HZ); - set_bit(ATH10K_SNOC_FLAG_UNREGISTERING, &ar_snoc->flags); ath10k_core_unregister(ar); -- 2.26.0