Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp696961pxu; Thu, 26 Nov 2020 09:18:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJw14xzXdd8/TC5SWHUqBQebv4tFi9WVm7vWKcf90AuQljCFbdGLvsc7Iq5guzQmjmIcuVHD X-Received: by 2002:a17:906:ad85:: with SMTP id la5mr3577446ejb.423.1606411110594; Thu, 26 Nov 2020 09:18:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606411110; cv=none; d=google.com; s=arc-20160816; b=UbjoasQdKO1XBoCqrKi1FHRXmF391AW445Mg0w+TuOa+rZ0KYr5LY3O/DnmKO8qf07 am9RSzFf6XC1cNw9V39Bppw377t0OjJjkrtjzDgiAcQHZULsICKv+/hTHoffKwS9/AeN 9iS9/ASSJNwRD0oDdPpp0waJDX8jSyOVAJooZGvSZ1G+mWEOqyIqB60hVqtfCdQgLD6u i6Oq+7E/E881D1UwgPSGYTwgKoRntJDtL8D3/qcn40Vmv33A5UNEx2mDhv6/TcGL871Q CTnj4EN/BvDLqtvEbykilf4of8YVsds3O/NBlWrwqd0g6I6qtXM+z/XFbn/pTNQ2uUOM 8i0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=aDTZg/Pn2FFXaBsM2zw6cq9czeh26ApRWnenhtnA7Cc=; b=vZlPjD8+ac7ktbrb2diUc5aWp5O41c1GtPduORotj6KbwTB4gt5x898VJIjjso+Atv W1gfLtv/3S1Empkjkk0m2UHDZdH4emhoo2wvl5BXxqaIMNtQo0025p9/VqavmJ9Bdqj0 mHu0UZgUPb728zRs/YgIU6QPmCdyHqHNHX7aDRIyvmQ5R/3PflBqg+5J5GpAnm609Ku2 KFiHcDj7f+miBWxWMqYbp7LnH8dl3fPsQ7gfDCmUQ+C3Bxv6D2SUJpROOQ1yRwQ9HLpx DgDBiKjocMuC3LhV3107bpt/uAr9rm/cpZjkQUuZmqLKZVmXtGm+H0rEITxRSY6P8j9t wOGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si3506927edw.461.2020.11.26.09.18.04; Thu, 26 Nov 2020 09:18:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391612AbgKZRQM (ORCPT + 99 others); Thu, 26 Nov 2020 12:16:12 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:44514 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391544AbgKZRQM (ORCPT ); Thu, 26 Nov 2020 12:16:12 -0500 Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 26 Nov 2020 09:16:12 -0800 X-QCInternal: smtphost Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 26 Nov 2020 09:16:09 -0800 X-QCInternal: smtphost Received: from youghand-linux.qualcomm.com ([10.206.66.115]) by ironmsg01-blr.qualcomm.com with ESMTP; 26 Nov 2020 22:45:57 +0530 Received: by youghand-linux.qualcomm.com (Postfix, from userid 2370257) id 3A2FC21B61; Thu, 26 Nov 2020 22:45:56 +0530 (IST) From: Youghandhar Chintala To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, pillair@codeaurora.org, dianders@chromium.org, kuabhs@chromium.org, briannorris@chromium.org, Youghandhar Chintala Subject: [PATCH v2] ath10k: skip the wait for completion to recovery in shutdown path Date: Thu, 26 Nov 2020 22:45:53 +0530 Message-Id: <20201126171553.2097-1-youghand@codeaurora.org> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Currently in the shutdown callback we wait for recovery to complete before freeing up the resources. This can lead to unwanted delay during the shutdown and thereby increase the shutdown time. As an attempt to take less time during shutdown, remove the wait for recovery completion in the shutdown callback. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Youghandhar Chintala --- Changes from v1: -Removed stray change-id text --- drivers/net/wireless/ath/ath10k/snoc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 84666f72bdfa..15580a91fe98 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1790,9 +1790,6 @@ static int ath10k_snoc_remove(struct platform_device *pdev) reinit_completion(&ar->driver_recovery); - if (test_bit(ATH10K_SNOC_FLAG_RECOVERY, &ar_snoc->flags)) - wait_for_completion_timeout(&ar->driver_recovery, 3 * HZ); - set_bit(ATH10K_SNOC_FLAG_UNREGISTERING, &ar_snoc->flags); ath10k_core_unregister(ar); -- 2.26.0