Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201204162428.2583119-1-eric.dumazet@gmail.com> <cac552ce70a747f078738a7167f0a75bc52fac7c.camel@sipsolutions.net>
In-Reply-To: <cac552ce70a747f078738a7167f0a75bc52fac7c.camel@sipsolutions.net>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 4 Dec 2020 17:51:06 +0100
Message-ID: <CANn89iKkKaD+rFfwaoWCMKmYhGd4jE_=nMWyVTaZQ4EXBKRZXQ@mail.gmail.com>
Subject: Re: [PATCH net] mac80211: mesh: fix mesh_pathtbl_init() error path
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Eric Dumazet <eric.dumazet@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>,
        syzbot <syzkaller@googlegroups.com>,
        linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 4, 2020 at 5:26 PM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Fri, 2020-12-04 at 08:24 -0800, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path)
> > while tbl_path rhashtable has not yet been initialized, which causes
> > panics.
>
> Thanks Eric!
>
> I was going to ask how you ran into this ...
>
> > Reported-by: syzbot <syzkaller@googlegroups.com>
>
> Until I saw this - but doesn't syzbot normally want a
> "syzbot+somehashid@..." as the reported-by?

Do not worry about this, I will not release the syzbot publicly, no
need to add more noise to various mailing lists for such a trivial
patch.
(This particular syzbot report included yet a buggy bisection, lets
not get yet another replies from annoyed developers )

This is why we add a Reported-by: syzbot <syzkaller@googlegroups.com>,
only to let the syzbot teams count the number of syzbot bugs fixed.