Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Dec 2020 17:35:45 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Eric Dumazet <eric.dumazet@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        syzbot <syzkaller@googlegroups.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH net] mac80211: mesh: fix mesh_pathtbl_init() error path
Message-ID: <20201204173545.767203e9@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <03b6e1ab6d4d51f2a3dde7439fbc24c8a9a930c6.camel@sipsolutions.net>
References: <20201204162428.2583119-1-eric.dumazet@gmail.com>
        <03b6e1ab6d4d51f2a3dde7439fbc24c8a9a930c6.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 04 Dec 2020 17:29:39 +0100 Johannes Berg wrote:
> On Fri, 2020-12-04 at 08:24 -0800, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@google.com>
> > 
> > If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path)
> > while tbl_path rhashtable has not yet been initialized, which causes
> > panics.
> > 
> > Simply factorize the rhashtable_init() call into mesh_table_alloc()

> > Fixes: 60854fd94573 ("mac80211: mesh: convert path table to rhashtable")
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Reported-by: syzbot <syzkaller@googlegroups.com>  
> 
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> 
> Jakub, if you want to take it to the net tree I wouldn't mind at all,
> since I _just_ sent a pull request a little while ago.

Sure thing. 

Applied, thanks!