Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1035430pxu; Sat, 5 Dec 2020 01:57:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCmkDHvWDgUt8njXLk7H/pcaPuXoCaLaTBG7PfQ+hGZJCIQhZoGQLr/q8jLwnKNvL48G5i X-Received: by 2002:a17:906:385b:: with SMTP id w27mr10966778ejc.109.1607162269528; Sat, 05 Dec 2020 01:57:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607162269; cv=none; d=google.com; s=arc-20160816; b=dCQiB0vO3zH/1HYG3gmudo9RBcnncyL/vvAZmLxSfNw1pXz/z1irWzPGNF1Z5pGnEh VP5HfiSgBCc69JRJgjdDIT6iKks7mypH2jyUqXHLfE7ONYIcfnazClyrczTkrLI74gke 6SkJwpgdS5a2YzgJSlriOK+8W9CMlANQUogEhTZTbipRH3EllBWHNAx2nIKAwmLIKjjz eSZ4pPM9Othmzm7L6giyg2mt6AvGu59DMHqymT2wY8pJik2fWhOLJ9jhWVFCmEWSLza+ PvDC3jBf/Svd0GbAOTQXEPiKMyTfomsxlz1PxVYDHpaESBbIXNvfKot5eo8BKjGRREGI JRzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=SNPQPu5io7Fudwi0PqFpBHSwMJ0DegcYrkvh2xiSSto=; b=NFaUsToCHW5yTbfFI1C6gxijFpStH+r1zGswpR58b90eYPQPaBu9CCoB0/7h6N9IT+ gpuZvUD2AqN5YlqGsMT+bcSJfXtB/Dt2ea5ea1GSNTcKvHARxdLXM33fbfzHO0e5CWPe kaH6MdXvrhVFL9VrrfC6DMr14YLSphe2/rt+WBlbyltPNbHEMt50XUQ5r/aRkkujmiUq 21onqkm2p3XmUQvl6xBfI+h7BKTTcjT3fV5F+lrczCYGrRMkYBAa/CFEDC+ahQ1Prqsj M1cDgUM5KlRD4G46/nd/GU6PaWVWMsdVijPDlFEW+ykqD+IRomvD4GlShQ1CgOTx7jpv JcPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si467180eds.293.2020.12.05.01.57.17; Sat, 05 Dec 2020 01:57:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726701AbgLEJvc (ORCPT + 99 others); Sat, 5 Dec 2020 04:51:32 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:43615 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728781AbgLEJgO (ORCPT ); Sat, 5 Dec 2020 04:36:14 -0500 X-Greylist: delayed 521 seconds by postgrey-1.27 at vger.kernel.org; Sat, 05 Dec 2020 04:36:14 EST Received: from isengard.fritz.box (unknown [87.147.53.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id E8C4C58007E; Sat, 5 Dec 2020 10:26:29 +0100 (CET) From: Markus Theil To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Markus Theil , Marc Rantanen Subject: [PATCH] iw: use correct type in policy check for mesh Date: Sat, 5 Dec 2020 10:26:15 +0100 Message-Id: <20201205092615.131561-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org NL80211_STA_INFO_CONNECTED_TO_AS and NL80211_STA_INFO_CONNECTED_TO_GATE are defined as u8 in kernel, but were checked against NLA_FLAG. This fixes: root@openwrt:~# iw dev wlan0-mesh station failed to parse nested attributes! failed to parse nested attributes! failed to parse nested attributes! Reported-by: Marc Rantanen Tested-by: Marc Rantanen Signed-off-by: Markus Theil --- station.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/station.c b/station.c index b2c5b9c..bddea51 100644 --- a/station.c +++ b/station.c @@ -329,8 +329,8 @@ static int print_sta_handler(struct nl_msg *msg, void *arg) [NL80211_STA_INFO_ACK_SIGNAL] = {.type = NLA_U8 }, [NL80211_STA_INFO_ACK_SIGNAL_AVG] = { .type = NLA_U8 }, [NL80211_STA_INFO_AIRTIME_LINK_METRIC] = { .type = NLA_U32 }, - [NL80211_STA_INFO_CONNECTED_TO_AS] = { .type = NLA_FLAG }, - [NL80211_STA_INFO_CONNECTED_TO_GATE] = { .type = NLA_FLAG }, + [NL80211_STA_INFO_CONNECTED_TO_AS] = { .type = NLA_U8 }, + [NL80211_STA_INFO_CONNECTED_TO_GATE] = { .type = NLA_U8 }, }; char *chain; struct timeval now; -- 2.29.2