Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1053593pxu; Sat, 5 Dec 2020 02:40:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLOXQzfWzHA1gzKmVLvSTiOGbYRA7WJWyaFIxGK6g2BXGnScK6AYalvm4dr28H++hNwiWt X-Received: by 2002:aa7:cf8f:: with SMTP id z15mr8258240edx.17.1607164830554; Sat, 05 Dec 2020 02:40:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607164830; cv=none; d=google.com; s=arc-20160816; b=OpNNQKwO1zawOqJqq94XWX15tpqaioNKiPTk3a4o1rxAtRAJRhLQj2mjxoIVwbk/Ra yGMRK+QcGCTpsFvEZ2dgN0pfOycj53Zit+VCngJRZhMuv1WVlNCh7nurwp0XsyKzsc7x aOQ+eQj2Hxu+eBxIKQEvJYzU7400ZLI9SjoK4HHm24HDh3yMdoeErXblbMoAgHHwcuNy HiTrH7Ili3aU1UjNG9/KpqBW9kUGUWonob7hdZsMNFXHqCOplRXhPNAW+sft4E9k/+8f F7E3jI7NRPlct9AerlNtCza8q/jLkyYTHLvbgyotH+85hE72ixgcBbtT6MHTdw2RH1+y p3LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sRfrpySb6L+FtlGI8lgpMUT8WdAZy/w+0FD0RQFVppc=; b=S9Ywufm1GDn/yz8DIERrQZCbqtrEOuKOjXELJQcVUlNg3TJZcK+3XAuuNS33mH1VEe 2AFTuO5uWAveScPMja6+3UxGzc4mWmbKv85FyasFIDyr5t5WlnjEdq0lfUN4QCR3gAMc r0g9bfGpYlMn+1lx2fehmRTKK6GVR0P3CqULCJq9eGCja7Dlm9vaxappX4ed6ln7SIK2 IjvKnmcgYfZsA9cUsLkJPPqutn5Er35+khuJvNVoDZM8B2s+BHB5SDp6zvvvoMak3aPF xMsh9pzhr9lDipECFxfgY2NDkS0TJIlZhjP/PpMNTtPde1q9rp/iPTAg7ucre1qYqLB8 45Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h22si3084580ejd.179.2020.12.05.02.39.51; Sat, 05 Dec 2020 02:40:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728036AbgLEKiP (ORCPT + 99 others); Sat, 5 Dec 2020 05:38:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:45204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbgLEKgb (ORCPT ); Sat, 5 Dec 2020 05:36:31 -0500 From: Lorenzo Bianconi Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: nbd@nbd.name Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org Subject: [PATCH 2/2] mt76: sdio: remove wake logic in mt76s_process_tx_queue Date: Sat, 5 Dec 2020 11:35:26 +0100 Message-Id: X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Similar to mmio/usb code path, remove wake logic in mt76s_process_tx_queue routine Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/sdio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/sdio.c b/drivers/net/wireless/mediatek/mt76/sdio.c index 62b5b912818f..7cd995118257 100644 --- a/drivers/net/wireless/mediatek/mt76/sdio.c +++ b/drivers/net/wireless/mediatek/mt76/sdio.c @@ -157,7 +157,7 @@ static void mt76s_net_worker(struct mt76_worker *w) static int mt76s_process_tx_queue(struct mt76_dev *dev, struct mt76_queue *q) { - bool wake, mcu = q == dev->q_mcu[MT_MCUQ_WM]; + bool mcu = q == dev->q_mcu[MT_MCUQ_WM]; struct mt76_queue_entry entry; int nframes = 0; @@ -177,21 +177,12 @@ static int mt76s_process_tx_queue(struct mt76_dev *dev, struct mt76_queue *q) nframes++; } - wake = q->stopped && q->queued < q->ndesc - 8; - if (wake) - q->stopped = false; - if (!q->queued) wake_up(&dev->tx_wait); - if (mcu) - goto out; - - mt76_txq_schedule(&dev->phy, q->qid); + if (!mcu) + mt76_txq_schedule(&dev->phy, q->qid); - if (wake) - ieee80211_wake_queue(dev->hw, q->qid); -out: return nframes; } -- 2.28.0