Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: pillair=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 317A4C433C6
From:   "Rakesh Pillai" <pillair@codeaurora.org>
To:     "'Abhishek Kumar'" <kuabhs@chromium.org>, <kvalo@codeaurora.org>
Cc:     <linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
        <ath10k@lists.infradead.org>, <briannorris@chromium.org>,
        <dianders@chromium.org>, "'David S. Miller'" <davem@davemloft.net>,
        "'Jakub Kicinski'" <kuba@kernel.org>, <netdev@vger.kernel.org>
References: <20201207231824.v3.1.Ia6b95087ca566f77423f3802a78b946f7b593ff5@changeid>
In-Reply-To: <20201207231824.v3.1.Ia6b95087ca566f77423f3802a78b946f7b593ff5@changeid>
Subject: RE: [PATCH v3] ath10k: add option for chip-id based BDF selection
Date:   Tue, 8 Dec 2020 10:31:42 +0530
Message-ID: <005d01d6cd1f$3c469ff0$b4d3dfd0$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQCE8JkGD3TKZlrmAmVZX18lYRS3TayQXLQA
Content-Language: en-us
Precedence: bulk

Hi,


> -----Original Message-----
> From: Abhishek Kumar <kuabhs@chromium.org>
> Sent: Tuesday, December 8, 2020 4:50 AM
> To: kvalo@codeaurora.org
> Cc: linux-kernel@vger.kernel.org; kuabhs@chromium.org; linux-
> wireless@vger.kernel.org; ath10k@lists.infradead.org;
> pillair@codeaurora.org; briannorris@chromium.org;
> dianders@chromium.org; David S. Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; netdev@vger.kernel.org
> Subject: [PATCH v3] ath10k: add option for chip-id based BDF selection
> 
> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
> 
> The board name with chip-id as option looks as follows
> board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'
> 
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1
> Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
> Signed-off-by: Abhishek Kumar <kuabhs@chromium.org>
> ---
> 
> Changes in v3:
> - Resurreted Patch V1 because as per discussion we do need two
> fallback board names and refactored ath10k_core_create_board_name.
> 
>  drivers/net/wireless/ath/ath10k/core.c | 41 +++++++++++++++++++-------
>  1 file changed, 30 insertions(+), 11 deletions(-)

Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>

Thanks,
Rakesh Pillai.