Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2989238pxu; Mon, 7 Dec 2020 23:59:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjWrGULKBFj0XRAagFG5f0YBmo9LeCm5vwKe2k9bVcwhKg/AL1m0TxaICa3EE+/MizSzK6 X-Received: by 2002:a17:907:2061:: with SMTP id qp1mr21509677ejb.222.1607414387446; Mon, 07 Dec 2020 23:59:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607414387; cv=none; d=google.com; s=arc-20160816; b=is1e6hVLuhkLmHoh8bmRKLZ98Rb81O/azswLofJHQ+6kCuZy/l9X2Ph4uQ6d4nSzi3 00jzsYZ994KBfaoxco9WAsNXRN+6qLMHNzmWJmZf/erIeAvx0L4WRI2R8H7vM4QiiE9E pLtAWYrGCBUhesRFWyAAPRN6UCzep8gvZHmh8RxRPi5Rt+NGSYtMJk+U5pyZ+Zvgb7YM G806rMHam9s2Z6dMzxp0G9oy+BKvyLS+vCt6Z4vNnFhJaJjSCcDRrrDvDASkyacK4Gam k1d7c3AgOMb7rU6rA9pBtHojpatPelTKkmwQKVrHri3zlIXBNk63kPlrX8h4EfTeCasF toYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=2Mn2Pc9dXqsIJzPbjlcSc+dZ+VvEsmsUdo0W18MYg2E=; b=mctQ+3nOY7IoBeOVopKUNxmAtkorTr/CAsxV6IuEcyonYqag1Vga48Hg9c7NKYxvEA QGXRQcz/V2Uwz40euPfJ3SBNxKgVbdmouMFQmeBPeas8nGxk3+adnThF64/jr0a2VVri qW3uSFuE93qoxtJmCd0CDomWXAyfGG6pKZuXEKDqAxAXCj2KH5dJ+c0XtWg5U/0QWs9o YFp7cH3rGE8WJ/5uql0mEYTAao6jtkB+oRJbbQpy5ZcJNj9Nb4RGZaDkU9wiTlFr9F5R OOE+fqJSeaqDl8IZke8CkE8xGUivV+AfDgQihPisSIKbpcDwrPl9+QOpc2hCPTqFBmys 8Vbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="Nl//Y/Ea"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si4230002edt.283.2020.12.07.23.59.23; Mon, 07 Dec 2020 23:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="Nl//Y/Ea"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbgLHH6N (ORCPT + 99 others); Tue, 8 Dec 2020 02:58:13 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:60792 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727468AbgLHH6N (ORCPT ); Tue, 8 Dec 2020 02:58:13 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1607414267; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=2Mn2Pc9dXqsIJzPbjlcSc+dZ+VvEsmsUdo0W18MYg2E=; b=Nl//Y/EafZOMRVd+4U8UNdTbfE+dtlLmkosk+5cNWZWCZTf9JmVxX0JukckPf6VmC3TqHirV Ue9UHWBbDlLswJgWBFq2CjkisfRjMGWvBoq2WwFw3OBUJcDS1rJ/JVQYvqFjozB9iBUjGSNg O4vpjd5zmb7tUcO/JeOJ4jpL6GE= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5fcf31fab50fb3818a95590b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 08 Dec 2020 07:57:46 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D2DA6C43461; Tue, 8 Dec 2020 07:57:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B32C6C433C6; Tue, 8 Dec 2020 07:57:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B32C6C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] ath10k: add option for chip-id based BDF selection From: Kalle Valo In-Reply-To: <20201207231824.v3.1.Ia6b95087ca566f77423f3802a78b946f7b593ff5@changeid> References: <20201207231824.v3.1.Ia6b95087ca566f77423f3802a78b946f7b593ff5@changeid> To: Abhishek Kumar Cc: linux-kernel@vger.kernel.org, kuabhs@chromium.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, pillair@codeaurora.org, briannorris@chromium.org, dianders@chromium.org, "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201208075745.D2DA6C43461@smtp.codeaurora.org> Date: Tue, 8 Dec 2020 07:57:45 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Abhishek Kumar wrote: > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option looks as follows > board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 > Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 > Signed-off-by: Abhishek Kumar > Reviewed-by: Douglas Anderson > Reviewed-by: Rakesh Pillai > Signed-off-by: Kalle Valo Two new checkpatch (using ath10k-check) warnings: drivers/net/wireless/ath/ath10k/core.c:1509: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath10k/core.c:1518: line length of 92 exceeds 90 columns Fixed those in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/patch/20201207231824.v3.1.Ia6b95087ca566f77423f3802a78b946f7b593ff5@changeid/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches