Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201203185732.9CFA5C433ED@smtp.codeaurora.org>
 <20201204111715.04d5b198@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
 <87tusxgar5.fsf@codeaurora.org> <CA+ASDXNT+uKLLhTV0Nr-wxGkM16_OkedUyoEwx5FgV3ML9SMsQ@mail.gmail.com>
 <20201207121029.77d48f2c@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> <bd5f9ded-e575-705b-a56b-a92f7765235f@gmail.com>
In-Reply-To: <bd5f9ded-e575-705b-a56b-a92f7765235f@gmail.com>
From:   Brian Norris <briannorris@chromium.org>
Date:   Tue, 8 Dec 2020 18:23:57 -0800
Message-ID: <CA+ASDXMv1jhJP6PZar7-R5WMBe-h+4tRcZ_M1k7sZT9_XUXQLQ@mail.gmail.com>
Subject: Re: pull-request: wireless-drivers-next-2020-12-03
To:     Edward Cree <ecree.xilinx@gmail.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Kalle Valo <kvalo@codeaurora.org>,
        "<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 8, 2020 at 7:01 AM Edward Cree <ecree.xilinx@gmail.com> wrote:
> My understanding is that it's because users can have them in their
>  modprobe.conf, which causes breakage if an update removes the param.
>  I think the module insert fails if there are unrecognised parameters
>  there.

That's a nice understanding, but I believe it's an incorrect one:

# echo 'options rtw88_pci doesnotexist=helloworld' >> /etc/modprobe.d/rtw.conf
# modprobe rtw88_pci; echo $?
0

In fact, while I was already quite aware about the removal Jakub is
highlighting (in the rtw88 driver), I was a user of the parameter, and
was quite happy to see it die (because now the driver does the Right
Thing automatically). I still left the option in my modprobe.conf,
while I finished staging upgrades of all my systems. I ran into no
problems, and now that the migration is done, I killed the
modprobe.conf entry.

Brian