Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1408745pxu; Thu, 17 Dec 2020 09:15:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnq35akZ7PNi8jLNII2G+wAZ5wdKGxEZ8YYPUV/lqXRy5+4l5C3ORs894KU77ycfbczo7D X-Received: by 2002:a17:906:f1c8:: with SMTP id gx8mr36439000ejb.524.1608225324651; Thu, 17 Dec 2020 09:15:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608225324; cv=none; d=google.com; s=arc-20160816; b=l+12eJ0dFVt5qC+ZyYgVMWBSQB5iMzeI91uSkP692X8UqE5XdYBNKQLq5IqbP1uBO/ +hTGjXLv9b5d3j/F0vLA10wbutQFhJMt+MCR+X5ujjbf2MYL/msD2LEU5vGRZxE7LhSV 2slz1nNDYITZ+XcwN+MffAD/WK6gaoeamYDGQ7BGiOGPrbgm4YwQsgUC4sN067v7kf3b /Fs59UX2/UWACoKiHCyZp86+e89KnZbILvCd/2sI2FpPAiM1YpKqFGE8aEz7RZRsP++X Uxmv9KNM7F1A2qRpcjF4RRoZja311pN4hICQgm+V1y3dFFA1X32wrAA6JesOBYN2x8An ECJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=i/Hv6kJp9s5d3WIMkY3jkR/F8YZH/7i8An5bfZ6lt8M=; b=WCymNU5o01y3tHKaXXXVRqOBgbFQg4pUdaw82huKEswtmWLmYNc1vbryJpHkRuZzCs LSbTdLQ9Ps8rWq+oeqC0+OaEIPiDX+e3hXPlsbKS6AGaLY9X2pEvfZSa93Q6PEqSbBej mr9/G2M+xjLjt/Q3zIEhtI6s3DgJC/idtPKw+kGw1h1CNIeMNAm96vRvbgAhyGgZR2uN uPMchhjj2rSYntJWq3hG0ZAeq1wRCYuNlTxa6Gia/hwxYystoGlJMJbngUNHv9L8wEBc nXf1Zt3+tzahPjWIV/fatcdHV6gGiVr90MZEKF18vsy+sBaxAYumIrlQL2NBwLrxz7G0 UorA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KmUD8O/l"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si2911519ejv.71.2020.12.17.09.15.00; Thu, 17 Dec 2020 09:15:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KmUD8O/l"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbgLQRLu (ORCPT + 99 others); Thu, 17 Dec 2020 12:11:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:38502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727414AbgLQRLu (ORCPT ); Thu, 17 Dec 2020 12:11:50 -0500 Date: Thu, 17 Dec 2020 18:11:05 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608225069; bh=i/Hv6kJp9s5d3WIMkY3jkR/F8YZH/7i8An5bfZ6lt8M=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=KmUD8O/lm/sKyejUUoGnYeZXWiR/T3cil14bKVzIIhFnJKq0rFDejl8i7U16uZbOv FmI5lfTAOgjcennsjVhVhzNWwLbGmm+/xzknOJZpv5k3u3X9kKgapt3XLlsRDqGnsZ JgIOzBYb5hdW0V3bvB23Tsr2bf0EcOsyw9f+bVKrzOSbl0qZ93HAIKrDoyRfQywFu/ n4eGUp2+18l7v/9ytr6weGViDsGv1wuLk6y22jZ2S6CDvolhOXVm2PWzzC21hDasSa ONXYLW9uDX9biw1Gg/HiuZFnukQYuqg8e1xY8/Ga8ob4a8yOk4ZW5Iwhf2v8DxtQwM F7WVUf+m2Gnqg== From: Lorenzo Bianconi To: Kalle Valo Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com Subject: Re: [PATCH] mt76: mt76s: fix NULL pointer dereference in mt76s_process_tx_queue Message-ID: <20201217171105.GC16606@lore-desk> References: <20201217163616.546AFC433CA@smtp.codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: <20201217163616.546AFC433CA@smtp.codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Lorenzo Bianconi wrote: >=20 > > Fix a possible NULL pointer dereference in mt76s_process_tx_queue that > > can occur if status thread runs before allocating tx queues > >=20 > > Fixes: 6a618acb7e62 ("mt76: sdio: convert {status/net}_work to mt76_wor= ker") > > Signed-off-by: Lorenzo Bianconi >=20 > Failed to apply to wireless-drivers: Hi Kalle, sorry for the noise. I guess to apply this patch we need to apply even the following series: https://patchwork.kernel.org/project/linux-wireless/cover/cover.1607164041.= git.lorenzo@kernel.org/ @Felix: do you think it is ok to apply "remove wake queue tx logic for usb/sdio" series to wireless-drivers? If not I can rebase this path ontop of current wireless-drivers tree. Regards, Lorenzo >=20 > fatal: sha1 information is lacking or useless (drivers/net/wireless/media= tek/mt76/sdio.c). > error: could not build fake ancestor > Applying: mt76: mt76s: fix NULL pointer dereference in mt76s_process_tx_q= ueue > Patch failed at 0001 mt76: mt76s: fix NULL pointer dereference in mt76s_p= rocess_tx_queue > The copy of the patch that failed is found in: .git/rebase-apply/patch >=20 > Patch set to Changes Requested. >=20 > --=20 > https://patchwork.kernel.org/project/linux-wireless/patch/b49c1b4edacd87b= 2241a9fd0431dd4864c8963f6.1607418933.git.lorenzo@kernel.org/ >=20 > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa= tches >=20 --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCX9uRJgAKCRA6cBh0uS2t rDdZAQDdPlP+pg5MxtMYRslw/lLKt+QhA/j/Czf0EjjQLNiTjwEAgBmv5VSGgpyi Chbb4cvymZwZP+qcZnvw93vmjShBmw0= =+cpr -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--