Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 20:07:53 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     kvalo@codeaurora.org
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mt76: sdio: remove wake logic in
 mt76s_process_tx_queue
Message-ID: <20201217190753.GF16606@lore-desk>
References: <cover.1607164041.git.lorenzo@kernel.org>
 <d2d7d9d437f4dec2ef1df0ed070b9cf299f021ad.1607164041.git.lorenzo@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="L2Brqb15TUChFOBK"
Content-Disposition: inline
In-Reply-To: <d2d7d9d437f4dec2ef1df0ed070b9cf299f021ad.1607164041.git.lorenzo@kernel.org>
Precedence: bulk


--L2Brqb15TUChFOBK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Similar to mmio/usb code path, remove wake logic in mt76s_process_tx_queue
> routine

Starting from commit '90d494c99a99fa2eb858754345c4a9c851b409a0
("mt76: improve tx queue stop/wake")', the wake queue logic on
the sdio status path is no longer necessary since the hw queues
are no longer stopped on the mt76 tx path.

Regards,
Lorenzo

>=20
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  drivers/net/wireless/mediatek/mt76/sdio.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/sdio.c b/drivers/net/wire=
less/mediatek/mt76/sdio.c
> index 62b5b912818f..7cd995118257 100644
> --- a/drivers/net/wireless/mediatek/mt76/sdio.c
> +++ b/drivers/net/wireless/mediatek/mt76/sdio.c
> @@ -157,7 +157,7 @@ static void mt76s_net_worker(struct mt76_worker *w)
> =20
>  static int mt76s_process_tx_queue(struct mt76_dev *dev, struct mt76_queu=
e *q)
>  {
> -	bool wake, mcu =3D q =3D=3D dev->q_mcu[MT_MCUQ_WM];
> +	bool mcu =3D q =3D=3D dev->q_mcu[MT_MCUQ_WM];
>  	struct mt76_queue_entry entry;
>  	int nframes =3D 0;
> =20
> @@ -177,21 +177,12 @@ static int mt76s_process_tx_queue(struct mt76_dev *=
dev, struct mt76_queue *q)
>  		nframes++;
>  	}
> =20
> -	wake =3D q->stopped && q->queued < q->ndesc - 8;
> -	if (wake)
> -		q->stopped =3D false;
> -
>  	if (!q->queued)
>  		wake_up(&dev->tx_wait);
> =20
> -	if (mcu)
> -		goto out;
> -
> -	mt76_txq_schedule(&dev->phy, q->qid);
> +	if (!mcu)
> +		mt76_txq_schedule(&dev->phy, q->qid);
> =20
> -	if (wake)
> -		ieee80211_wake_queue(dev->hw, q->qid);
> -out:
>  	return nframes;
>  }
> =20
> --=20
> 2.28.0
>=20

--L2Brqb15TUChFOBK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCX9ushgAKCRA6cBh0uS2t
rMoXAP0TAvzxxZvTve9cRp+TQ0j5bBWOGEJ3bqQ3cQygOOz95wEAm4uKggyqlWBS
8M4NbG3DCTum1xIKiNVFbUPJQTMNWgs=
=z043
-----END PGP SIGNATURE-----

--L2Brqb15TUChFOBK--