Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Dec 2020 20:10:17 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     kvalo@codeaurora.org
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mt76: usb: remove wake logic in mt76u_status_worker
Message-ID: <20201217191017.GG16606@lore-desk>
References: <cover.1607164041.git.lorenzo@kernel.org>
 <00009bf0cfdc9565e4432cad3ed51888c667c25d.1607164041.git.lorenzo@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="reI/iBAAp9kzkmX4"
Content-Disposition: inline
In-Reply-To: <00009bf0cfdc9565e4432cad3ed51888c667c25d.1607164041.git.lorenzo@kernel.org>
Precedence: bulk


--reI/iBAAp9kzkmX4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Similar to mmio code path, remove wake logic in mt76u_status_worker
> handler

Starting from commit '90d494c99a99fa2eb858754345c4a9c851b409a0
("mt76: improve tx queue stop/wake")', the wake queue logic on
the usb status path is no longer necessary since the hw queues
are no longer stopped on the mt76 tx path.

Regards,
Lorenzo

>=20
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  drivers/net/wireless/mediatek/mt76/usb.c | 7 -------
>  1 file changed, 7 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wirel=
ess/mediatek/mt76/usb.c
> index 81393788f98e..658b36a2281d 100644
> --- a/drivers/net/wireless/mediatek/mt76/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/usb.c
> @@ -811,7 +811,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
>  	struct mt76_dev *dev =3D container_of(usb, struct mt76_dev, usb);
>  	struct mt76_queue_entry entry;
>  	struct mt76_queue *q;
> -	bool wake;
>  	int i;
> =20
>  	for (i =3D 0; i < IEEE80211_NUM_ACS; i++) {
> @@ -827,10 +826,6 @@ static void mt76u_status_worker(struct mt76_worker *=
w)
>  			mt76_queue_tx_complete(dev, q, &entry);
>  		}
> =20
> -		wake =3D q->stopped && q->queued < q->ndesc - 8;
> -		if (wake)
> -			q->stopped =3D false;
> -
>  		if (!q->queued)
>  			wake_up(&dev->tx_wait);
> =20
> @@ -839,8 +834,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
>  		if (dev->drv->tx_status_data &&
>  		    !test_and_set_bit(MT76_READING_STATS, &dev->phy.state))
>  			queue_work(dev->wq, &dev->usb.stat_work);
> -		if (wake)
> -			ieee80211_wake_queue(dev->hw, i);
>  	}
>  }
> =20
> --=20
> 2.28.0
>=20

--reI/iBAAp9kzkmX4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCX9utFgAKCRA6cBh0uS2t
rED0AQCKrkvnVaMZZjn6ox0k6DjZeDP7BNMgcwAiNvqXYtFyaAEA8g3cO1f4Njtl
Q0o2wQyE8W1OlrHQXPR3Je2jlwglCAU=
=mQJ6
-----END PGP SIGNATURE-----

--reI/iBAAp9kzkmX4--