Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4503172pxu; Mon, 21 Dec 2020 14:26:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTK7yXoPDxcAKWUQkmIWqjj+n461rarTTr9+sYlZaNTaFZ+yLx/3kr8qA8YDpwzUqOn3Le X-Received: by 2002:a50:d4d9:: with SMTP id e25mr17845482edj.243.1608589602949; Mon, 21 Dec 2020 14:26:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608589602; cv=none; d=google.com; s=arc-20160816; b=l35ZxDzDJN+mBg7+431ed6s38UtSsUJbtrRQvWD5vaT5VhMdnNphSDpWGOq1h4Zvxu flOWlaE+58ogcl22kbxqnTUpARVgJ5pBmMgDjvzo4gVXZA97pKSIHFtE/bPRXnYChmgm njlakbbrx1KbOThS7OP6k+8DV0Y6panyuPVbr5R9b/NPcjOGkXZnSSniozEmX1RYjrNb uS54rPn6NOH5s7hizM5PYw71WIndf792dw4Jtx858hJ+2YhGysB9p3o0i9/1FAdNfelk YtWL8gd+Ydi41kUSSboSqTX3PIy617e0JtNCpgAcU/0JrCjfuyVT+HC9z+do4oYjDip9 sViw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:dkim-signature:dkim-filter; bh=BBanstmsx4tbuMVGHqqgse0TI3Lm38zwauMruCe3EME=; b=gH6o8RW0Ap6Adk9q9/3KVNPyTYX367yL5BWiTSMi0d/vrFdZ+DZZ7gH/grclaKAwQa kKD4HR/AKU7ls4KvkojFU7t/qXQz/OQwqhXrUPmzH1Tes5P41KMzv3R8REOunrCMQ+ku pCHl8ibaU4LGcoo0b+3rn3zpKanTKqxVrQ+ygDsbyKnWiY4mA6coiGwFznC1AUTudto7 D5nwQtl9lcR1hvNIOhvGapJpBxtSysbmwXgqgUzkatxM++pYjrRNU/55QqzbdqrtCY2w gPFRyqUaraxiLvZTwfSW6ON665nvaZAlpFw5vhG00ucCM4PbN9fXMLsFxhZA/yDGWjAk Wddg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=EOXB7iDH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck9si10536783edb.586.2020.12.21.14.26.17; Mon, 21 Dec 2020 14:26:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=EOXB7iDH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725783AbgLUWWW (ORCPT + 99 others); Mon, 21 Dec 2020 17:22:22 -0500 Received: from mail2.candelatech.com ([208.74.158.173]:53908 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgLUWWW (ORCPT ); Mon, 21 Dec 2020 17:22:22 -0500 Received: from [192.168.254.6] (unknown [50.46.158.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 2539113C2B0; Mon, 21 Dec 2020 14:21:42 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 2539113C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1608589302; bh=u1kcYItexzSqhZ/LdK+cgKFiRExwyVnWjAL3XOvHJuA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=EOXB7iDHKaoeaTVuZOuPrO5CYcPhkz6qwxS8sU5bwEb5tCaLbQCQZPDI4PYAEw6GD aPbOarnxWa2oM0+upV4JA8qNF4wkZfwT/BF4gJbTzcMT7d43MleUeTDxFPwTTpxEMM E2WjNVO+yMAO5FTQVa8+41GSAMYIb6tHD1XU8g0U= Subject: Re: [PATCH v2] ath10k: Per-chain rssi should sum the secondary channels To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org References: <20191217183343.25585-1-greearb@candelatech.com> <20201221183044.9016DC433C6@smtp.codeaurora.org> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Mon, 21 Dec 2020 14:21:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201221183044.9016DC433C6@smtp.codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 12/21/20 10:30 AM, Kalle Valo wrote: > greearb@candelatech.com wrote: > >> From: Ben Greear >> >> This makes per-chain RSSI be more consistent between HT20, HT40, HT80. >> Instead of doing precise log math for adding dbm, I did a rough estimate, >> it seems to work good enough. >> >> Tested on ath10k-ct 9984 firmware. >> >> Signed-off-by: Ben Greear > > Commented out code etc so I assume this is an RFC. Has anyone tested > this with upstream firmware? I probably tweaked this patch since sending. my wave-1 didn't work with this approach, and in the end, to get a valid RSSI, I ended up reading the per-chain noise-floor periodically and storing that so I could use proper noise-floor instead of just -95. I am not sure upstream firmware can support that, so probably not worth adding just the sum logic unless someone can figure out how to get the noise floor out of the firmware... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com