Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp4550868pxu; Mon, 21 Dec 2020 15:57:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJxEZwcu34pZlkqvVnu/zFtZLPCTTpqEleyICau1lWJ3lsUyv2xDIfHbKLHy/0l9YGlUjzjE X-Received: by 2002:a05:6402:366:: with SMTP id s6mr17969859edw.44.1608595065823; Mon, 21 Dec 2020 15:57:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608595065; cv=none; d=google.com; s=arc-20160816; b=NKKgLwNbsWhpzFlN7A8oGsXXzUMCtQsyNAyA4M/kzZfqOJgUC3UEr34zDF5x3r0/la /an/KkdF6rajtCpoFvJ4c67O1XRctKImbY/AnzxbGE3YJ2LdkyQ7Hs5YftN7Nj/TkXXI Uh/Xx20nwGxjqV+Zwa0BtMCjT0EeFIW+eUoWT+hUNLjhDtvrCN0WfgijzIUhqTZpyJ0q /ZviXUFCgyeqDzbTiwPp1Qw71TpCLRjwIH6i0oEi7zJYxWZnk1Ga0kQszCfUh/feX75L EP9EJUmc7Ex0jUZ8RLC5mhNljw+J918Vy/nJGqUww7AKsZ5OfjxHyN8FKGow55rKcNYI S1GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:user-agent:date:message-id:organization:subject:from :to:dkim-signature:dkim-filter; bh=vgJb8HF6NA1Nx4E6obf75152ibDefQv2958FnZu9Nmk=; b=mH3eQe9VFJT/wqPtARkDJSWz0EA/JEMEfquoelWBd7lu1CKVksJBw+wMW1G+hmW28f /9m7S2jGI2NWD7zg/Akp5iiUrAorOIF9M99v2kgfLuCzYIzDnyx4yFph3JpSLhEXnymP h62EtFfopwYYNHOIS97YKC4wRls3F3YQRZ0uOOcRgqBrkbUNmu0iglxCelUcY3rqZuRl HH2q2nFa8V7zzmb8OY0XG9XBVlPnZ4I+nXwaqD9TxrCYprA66DXKfaci0Rmdk0nzX5e+ 4PU6/Efz4btwrZkEHHo/8xFnBjO9CDSsjbeJlwAS8dKmesTFk+Qc/aQmErBl4DXNqM90 hh2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b="ogR/GZ1O"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si9478997ejk.634.2020.12.21.15.57.16; Mon, 21 Dec 2020 15:57:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b="ogR/GZ1O"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725783AbgLUX4N (ORCPT + 99 others); Mon, 21 Dec 2020 18:56:13 -0500 Received: from mail2.candelatech.com ([208.74.158.173]:56170 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgLUX4N (ORCPT ); Mon, 21 Dec 2020 18:56:13 -0500 Received: from [192.168.254.6] (unknown [50.46.158.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id D6CAB13C2B0; Mon, 21 Dec 2020 15:55:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com D6CAB13C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1608594933; bh=F7ozhtwuhrGggN6wJ+krzNZQfpP/UK5VVPFr3YEjxhQ=; h=To:From:Subject:Date:From; b=ogR/GZ1OPjUFX3TvDeoeHM1YmF9ARkn4sLw91wuApWn+vVHBfoLMgb3AZILxrpwgF m2CzWq1fQfzoS7QfTs6xa5uD2gnXYE94DLp7iIDJvZyjuqKEKWT9qQjJvu4t/gDLt+ Zl1+cKWfrGZeMZeoisK+QDR0gojVKcRyiOMMY0ow= To: "linux-wireless@vger.kernel.org" , ath10k From: Ben Greear Subject: skb_cb corruption in ath10k Organization: Candela Technologies Message-ID: <86170a90-da2f-3227-d7e5-fe9486156705@candelatech.com> Date: Mon, 21 Dec 2020 15:55:32 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hello, I'm trying to figure out what changed in the last few kernels that is making: struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); if (info->control.flags & IEEE80211_TX_CTRL_RATE_INJECT) /* why is code here all of a sudden */ in data frames in ath10k, when, to the best of my knowledge, nothing should be setting that up in the stack. My guess is that something is stepping on the cb field somewhere in ath10k, but I am not sure where that might be at this point. And it also appears mac80211 or maybe supplicant is setting the rate-inject flag on some mgt frames, but I think that is a separate concern at this point. If anyone has any ideas of likely points, please let me know. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com