Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp5192994pxu; Tue, 22 Dec 2020 10:30:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0whEiavJ7V2t7ERBu7Acq5mrMJ6LDBPCcWhCoG1cc54z5s4fgxQCGaIGBHvFhtyqrX3vX X-Received: by 2002:a05:6402:1c90:: with SMTP id cy16mr21697705edb.73.1608661810471; Tue, 22 Dec 2020 10:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608661810; cv=none; d=google.com; s=arc-20160816; b=EzIKuG//sTXngfZKZNHRSaDKP/fjl2xsQNPZdIB7U0aQMVj14b2kJZoAMraLjW3+gX oePMIQm4lB+WXa/T9+NP9nsyFZtleqgEeGiXD7TzxR9LvVDREqn9vMMQaSNpyGUjeon6 sazPF3kziPaZSH6zgB5KCov6vpVBIznJ5qYl6b3OCE15EDWMEgQq0DABrDwn1v46EurO KyQZmqpQN1MweQ8xvlFup/zcmxXFZu8/LMx944QnEu9Oa6LPFjAFImscwkvhlkh0/f21 VVWLELp/RSdht0Nb/qI3NSksIN5V3hQUT3FJHjrtsvUJtV3fwSD34E3LCmfOTGoDHgo+ hsSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=v2yaYNLY/2Egp8td6IEyrDogvPXVN2oX1ZgCRI1aJpw=; b=nr5HgY+EWUAvkNNx2ZdzqjRppAxGV+82v9nEa41ZtCqrWCU1r/SwjzWFDG8V61Gmmr CgpwmcOqwMjTfSYuaVIoGe3Wf0KR28GSWcguZKWZNU7H6wT1YWFhDBoNoIkustGpllAn IGiHr1dbFZBA/2XkvTTJ8txmOfXR0spA2NIukTxLHlY5w7ArLKIhg654nx4eh06HOz+z Y/pqCww7NUCawj9dIP+5eRlUCqu/Ep3J935R7LW3nqTZnTbZ1MUjQIpeUmURZtGtM2CD ZtwK10RokwpnZPDi532KC1FN8Y0z9oSxSgMGw58DlYtup/ZDIHjIosPGx10wt5yAAed3 Cesg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UyGc2LXc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l14si15045690edv.597.2020.12.22.10.29.42; Tue, 22 Dec 2020 10:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UyGc2LXc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725833AbgLVS1o (ORCPT + 99 others); Tue, 22 Dec 2020 13:27:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725300AbgLVS1o (ORCPT ); Tue, 22 Dec 2020 13:27:44 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE78C0613D3 for ; Tue, 22 Dec 2020 10:27:03 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id d20so12780021otl.3 for ; Tue, 22 Dec 2020 10:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=v2yaYNLY/2Egp8td6IEyrDogvPXVN2oX1ZgCRI1aJpw=; b=UyGc2LXc1kA1vAINEbUyBtkq1liuLGnZGnHW8D8jjlkmywJAJh4v+aH8SEnvo9If6B 2nb/wstlewkXJfht1E4j7JmQCmtHb94H5mFrf1XjmBojLoHwdiAPzF4uPrmGE419H/nt gYaH2fjep7r/3WPOq1NRTfKZI8EuFExBgDc68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=v2yaYNLY/2Egp8td6IEyrDogvPXVN2oX1ZgCRI1aJpw=; b=f6Rni3FyPH2PJ/sLRp/pFq+liXMPj4k5TePkmF/4GzBohkHVMaoOmvdugVAMA/baXp guSsR8VxxBbY31MO9GuEPJC4qvQv/UeCLZ/Fe+6psclACVXZfq4hCVCndVUeRvINYD/T PmdzCBY/5dcL63Rt1Ep7qPt9XgU8+Iw5t6xJIl9w0xqt3VIDjJxhLeCeKMZ3RQOvujfc FuCZL1J/Xn3hanSRmGtFcSKVeyPRoq1YaUraPnPZC+wi+30B87au61wk5PTye9FUT56j 174kL/5AcvYal99mjK1eZtvyO6cWGTMGgaI2cW3WopJQiJjnXy5ZBYcrpp/FHcs1wUm4 sCkw== X-Gm-Message-State: AOAM531xvZ0URH8C59A07OOf/vJRaDeZV7cdWSHst6hvCRVchO+tL2jm zwtSvh6NkvvoxIFSLB4HWSMh1O2ItpETvQ== X-Received: by 2002:a9d:892:: with SMTP id 18mr17319760otf.9.1608661622300; Tue, 22 Dec 2020 10:27:02 -0800 (PST) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com. [209.85.210.52]) by smtp.gmail.com with ESMTPSA id 73sm4665514otv.26.2020.12.22.10.27.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 10:27:01 -0800 (PST) Received: by mail-ot1-f52.google.com with SMTP id w3so12718969otp.13 for ; Tue, 22 Dec 2020 10:27:01 -0800 (PST) X-Received: by 2002:a05:6830:1c2d:: with SMTP id f13mr16902484ote.365.1608661620897; Tue, 22 Dec 2020 10:27:00 -0800 (PST) MIME-Version: 1.0 References: <1608618887-8857-1-git-send-email-miaoqing@codeaurora.org> In-Reply-To: <1608618887-8857-1-git-send-email-miaoqing@codeaurora.org> From: Brian Norris Date: Tue, 22 Dec 2020 10:26:47 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ath10k: fix wmi mgmt tx queue full due to race condition To: Miaoqing Pan Cc: ath10k , linux-wireless Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Dec 21, 2020 at 10:34 PM Miaoqing Pan wro= te: > > Failed to transmit wmi management frames: > > [84977.840894] ath10k_snoc a000000.wifi: wmi mgmt tx queue is full > [84977.840913] ath10k_snoc a000000.wifi: failed to transmit packet, dropp= ing: -28 > [84977.840924] ath10k_snoc a000000.wifi: failed to submit frame: -28 > [84977.840932] ath10k_snoc a000000.wifi: failed to transmit frame: -28 > > This issue is caused by race condition between skb_dequeue and > __skb_queue_tail. The queue of =E2=80=98wmi_mgmt_tx_queue=E2=80=99 is pro= tected by a > different lock: ar->data_lock vs list->lock, the result is no protection. Reviewed-by: Brian Norris