Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp10926528pxu; Wed, 30 Dec 2020 16:17:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJw6awTZJyD+xD3VWvn3fyVlUuUE911siAEooulLfV0Zw6gL8DTABJ2Q0pwDSr8oD9LmVOJq X-Received: by 2002:a17:906:16da:: with SMTP id t26mr50874304ejd.478.1609373879344; Wed, 30 Dec 2020 16:17:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609373879; cv=none; d=google.com; s=arc-20160816; b=Gf5CcTQJ1ox+zSWMEZBWHbJbIJwGv6b/nI8+gyfyhjLmHErNJlT4AEss67cs43reMS jL65euD+mvSrPQFEvCkj1mM6NxdZa1LelJuK4k65nxsQ8LTp4WdYE61bafH26tRsly4e jo08/ppcqwlcfQloH6HLv/eYjEDy5pnQEM1t/AY9Ey0EyyX1JidyXDcq+7SlXxe+bX0+ XINVR+T1tbB01X1+DpDReIuEZwAOksOzkZ17gpbXfW6vwg0/n4tM9ygEc7IHg7QNhM/F 03mYXVh9VdKO4gPO2ErTQFiPB0CqBjI/whaFQNAqPBVez9vb+VjM/vS9aDFMtT4eTytH 9FCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=CWy26zEfWnPl/pNe8L5mp0kr2V4lAKKYazmabbzLsqM=; b=LifdBmVB4RAgnZQeOdKsgwdDitUzydxSnKWOio9JsE52LbnSU43SFOeI/owX6HSyJ7 Cd3l0HYtGKPLoXu1GoOo/Uq4go/UKh0mTkTFHHreJokbl2FvDjMPMBNWJ39tGAGPCfr8 oWrP+QWvyk/m5Egl1MZURNQdR+7ZQj+YVDV1O4rm3lr8z4HZl0afk+hAjYl+BATe4UUm se1XtE/JIXXPtOZjYekjybyxvmtgB0lCPqOrlMa3KJeXvJYJ20HE57zkfTdjIZ7ZI/hZ Eqg3thjoTZx7TnXJAtvz1BuXEqib+u5xhvXWPxQD96qYhu7J6wgYGq/ifIt12IyWQyIi q54g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b="B/VC07KH"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si22246239ejw.561.2020.12.30.16.17.37; Wed, 30 Dec 2020 16:17:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b="B/VC07KH"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbgLaAGN (ORCPT + 99 others); Wed, 30 Dec 2020 19:06:13 -0500 Received: from mail2.candelatech.com ([208.74.158.173]:47720 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgLaAGN (ORCPT ); Wed, 30 Dec 2020 19:06:13 -0500 Received: from ben-dt4.candelatech.com (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id A66C213C2B7; Wed, 30 Dec 2020 16:05:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com A66C213C2B7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1609373132; bh=EgOrrtC4YhHgXlJn+I5ahTyMkr0l9CGLrIB7SLNkqzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B/VC07KHWmqJff6i9NnuWYiQm4BYXHbd72hi2fGwHAdHs4YeyXxoup0iARgLa8moD YAqluy0Jn+Qdszn/iXEUuLRWpT+drE89AsVnLSGSj+X2nGAIcvt60Jzb6mYBzvrkVY bgpjCJmR+hUtxna0foYSQXLvlrfeH4rK93pjc80Y= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: luca@coelho.fi, Ben Greear Subject: [PATCH 5/6] iwlwifi: Make warnings unique to aid debugging. Date: Wed, 30 Dec 2020 16:05:22 -0800 Message-Id: <20201231000523.14963-5-greearb@candelatech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201231000523.14963-1-greearb@candelatech.com> References: <20201231000523.14963-1-greearb@candelatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ben Greear So we can be certain what code is generating kernel error messages. Signed-off-by: Ben Greear --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 4 ++-- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c index 1386d8397204..44947c6436d5 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c @@ -491,7 +491,7 @@ static int iwl_run_unified_mvm_ucode(struct iwl_mvm *mvm, bool read_nvm) /* Will also start the device */ ret = iwl_mvm_load_ucode_wait_alive(mvm, IWL_UCODE_REGULAR); if (ret) { - IWL_ERR(mvm, "Failed to start RT ucode: %d\n", ret); + IWL_ERR(mvm, "run-mvm-ucode: Failed to start RT ucode: %d\n", ret); goto error; } iwl_dbg_tlv_time_point(&mvm->fwrt, IWL_FW_INI_TIME_POINT_AFTER_ALIVE, @@ -1455,7 +1455,7 @@ int iwl_mvm_up(struct iwl_mvm *mvm) ret = iwl_mvm_load_rt_fw(mvm); if (ret) { - IWL_ERR(mvm, "Failed to start RT ucode: %d\n", ret); + IWL_ERR(mvm, "mvm-up: Failed to start RT ucode: %d\n", ret); if (ret != -ERFKILL) iwl_fw_dbg_error_collect(&mvm->fwrt, FW_DBG_TRIGGER_DRIVER); diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c b/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c index baa83a0b8593..f31bdcfdc93e 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c @@ -355,7 +355,7 @@ static int iwl_pcie_gen2_send_hcmd_sync(struct iwl_trans *trans, } if (test_bit(STATUS_FW_ERROR, &trans->status)) { - IWL_ERR(trans, "FW error in SYNC CMD %s\n", cmd_str); + IWL_ERR(trans, "gen2: FW error in SYNC CMD %s\n", cmd_str); dump_stack(); ret = -EIO; goto cancel; -- 2.20.1