Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201231000523.14963-1-greearb@candelatech.com> <20201231000523.14963-3-greearb@candelatech.com>
In-Reply-To: <20201231000523.14963-3-greearb@candelatech.com>
From:   Julian Calaby <julian.calaby@gmail.com>
Date:   Thu, 31 Dec 2020 12:19:03 +1100
Message-ID: <CAGRGNgXx3tqzOjLcKA=+FDrQsad_Hn=KX_gC+P4DFX+r8e2Fnw@mail.gmail.com>
Subject: Re: [PATCH 3/6] iwlwifi: Allow per-device fwcfg files.
To:     Ben Greear <greearb@candelatech.com>
Cc:     linux-wireless@vger.kernel.org, Luciano Coelho <luca@coelho.fi>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ben,

On Thu, Dec 31, 2020 at 11:17 AM <greearb@candelatech.com> wrote:
>
> From: Ben Greear <greearb@candelatech.com>
>
> This allows one to set the NSS and some
> other low-level features for ax200 radios.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
> index 223c716d9fce..e2ae509d1650 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
> @@ -246,12 +246,16 @@ void iwl_dbg_cfg_load_ini(struct device *dev, struct iwl_dbg_cfg *dbgcfg)
>         const struct firmware *fw;
>         char *data, *end, *pos;
>         int err;
> +       char fname[128];
>
>         if (dbgcfg->loaded)
>                 return;
>
> -       /* TODO: maybe add a per-device file? */
> -       err = firmware_request_nowarn(&fw, "iwl-dbg-cfg.ini", dev);
> +       snprintf(fname, 127, "iwl-dbg-cfg-%s.ini", dev_name(dev));
> +       fname[127] = 0;
> +
> +       /* TODO: maybe add a per-device file?  Yes, did that. --Ben */

You probably don't need the comment anymore =)

> +       err = firmware_request_nowarn(&fw, fname, dev);

Would it make sense to fall back to "iwl-dbg-cfg.ini" if the
per-device one isn't available?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/