Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/6] iwlwifi: Allow per-device fwcfg files.
To:     Julian Calaby <julian.calaby@gmail.com>
Cc:     linux-wireless@vger.kernel.org, Luciano Coelho <luca@coelho.fi>
References: <20201231000523.14963-1-greearb@candelatech.com>
 <20201231000523.14963-3-greearb@candelatech.com>
 <CAGRGNgXx3tqzOjLcKA=+FDrQsad_Hn=KX_gC+P4DFX+r8e2Fnw@mail.gmail.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <8b14768d-4ddb-6cb0-e27a-1fd1d8d1e41e@candelatech.com>
Date:   Wed, 30 Dec 2020 18:47:04 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <CAGRGNgXx3tqzOjLcKA=+FDrQsad_Hn=KX_gC+P4DFX+r8e2Fnw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/30/20 5:19 PM, Julian Calaby wrote:
> Hi Ben,
> 
> On Thu, Dec 31, 2020 at 11:17 AM <greearb@candelatech.com> wrote:
>>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> This allows one to set the NSS and some
>> other low-level features for ax200 radios.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>>   drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
>> index 223c716d9fce..e2ae509d1650 100644
>> --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
>> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-cfg.c
>> @@ -246,12 +246,16 @@ void iwl_dbg_cfg_load_ini(struct device *dev, struct iwl_dbg_cfg *dbgcfg)
>>          const struct firmware *fw;
>>          char *data, *end, *pos;
>>          int err;
>> +       char fname[128];
>>
>>          if (dbgcfg->loaded)
>>                  return;
>>
>> -       /* TODO: maybe add a per-device file? */
>> -       err = firmware_request_nowarn(&fw, "iwl-dbg-cfg.ini", dev);
>> +       snprintf(fname, 127, "iwl-dbg-cfg-%s.ini", dev_name(dev));
>> +       fname[127] = 0;
>> +
>> +       /* TODO: maybe add a per-device file?  Yes, did that. --Ben */
> 
> You probably don't need the comment anymore =)
> 
>> +       err = firmware_request_nowarn(&fw, fname, dev);
> 
> Would it make sense to fall back to "iwl-dbg-cfg.ini" if the
> per-device one isn't available?

It would be fine with me, lets see if Luca has any interest in the patches
in general before I go tweaking on them...

Thanks,
Ben

> 
> Thanks,
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com