Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Subject: Re: [PATCH] drivers: net: wireless: realtek: Fix the word association
 defautly de-faulty
To:     Joe Perches <joe@perches.com>,
        Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        Julian Calaby <julian.calaby@gmail.com>
Cc:     Ping-Ke Shih <pkshih@realtek.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, zhengbin13@huawei.com,
        baijiaju1990@gmail.com,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <20210105101738.13072-1-unixbhaskar@gmail.com>
 <CAGRGNgX-JSPW8LSmAUbm=2jkx+K4EYdntCq6P2i8td0TUk7Nww@mail.gmail.com>
 <X/RD/pll4UoRJG0w@Gentoo>
 <CAGRGNgVHcOjt4at+tzgrPxn=04_Y3b16pihDw6xucg4Eh1GFSA@mail.gmail.com>
 <X/RQeqAikxaCO2o0@Gentoo>
 <d6ee8f44f9ca285f17bdec972bcd0abb89fe64d6.camel@perches.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <23353e52-8a50-2024-e5b0-591d4e2f720e@lwfinger.net>
Date:   Tue, 5 Jan 2021 12:09:19 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <d6ee8f44f9ca285f17bdec972bcd0abb89fe64d6.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/5/21 5:55 AM, Joe Perches wrote:
> On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote:
>> On 22:24 Tue 05 Jan 2021, Julian Calaby wrote:
>>> Hi Bhaskar,
> []
>>> and your change is just making this comment worse.
>> really??? Not sure about it.
> 
> I agree with Julian.  I'm fairly sure it's worse.
> The change you suggest doesn't parse well and is extremely odd.
> If you _really_ want to just change this use (and the others),
> I repeat his suggestion of "by default".

I agree with Julian and Joe. Your suggested change makes it worse!

To match ALL previous commits/patches for these drivers, the subject should be 
"rtlwifi: <driver_name>: Fix description of usage of own bit in descriptor"

For all drivers, that comment should be written as:
         /* By default, a beacon packet will only use the first
          * descriptor and the own bit may not be cleared by the hardware
          */

Larry