Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To:     Ryder Lee <ryder.lee@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org,
        Ryder Lee <ryder.lee@mediatek.com>
Subject: Re: [PATCH] mac80211: check ATF flag in ieee80211_next_txq()
In-Reply-To: <d9aef825d186a91ff91f6a81045d49d375533b14.1609894402.git.ryder.lee@mediatek.com>
References: <d9aef825d186a91ff91f6a81045d49d375533b14.1609894402.git.ryder.lee@mediatek.com>
Date:   Wed, 06 Jan 2021 11:51:07 +0100
Message-ID: <87r1my49us.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ryder Lee <ryder.lee@mediatek.com> writes:

> The selected txq should be scheduled unconditionally if
> NL80211_EXT_FEATURE_AIRTIME_FAIRNESS is not set by driver.
>
> Also put the sta to the end of the active_txqs list if
> deficit is negative then move on to the next txq.

Why is this needed? If the feature is not set, no airtime should ever be
accounted to the station, and so sta->airtime[txqi->txq.ac].deficit will
always be 0 - so you're just adding another check that doesn't actually
change the behaviour, aren't you?

-Toke