Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3162922pxb; Tue, 12 Jan 2021 07:49:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKgeT6aLUv2icj7ipZ4n2zTIgyuDhTaHbebZO6wzQIh1IcXb4GCDWdNMLMmOMiop/JeteF X-Received: by 2002:a05:6402:b42:: with SMTP id bx2mr3882150edb.117.1610466573098; Tue, 12 Jan 2021 07:49:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610466573; cv=none; d=google.com; s=arc-20160816; b=eQfD4FjqZP03YYEeL6Ucby3HhR9efDy//v8cJDZaxvpfB0INno4Kn2Kezz8DFzaWki ZOx7aCEx0ez+EIP/visXKigchOJNWWPsUpTI4cXKGrl/ezeoAMJyusjiUvvCAmbM0itD PJdHavvFmoR5cnn6hMfuYx7tSblnFJtTvyC5Gkz8eBD6s317GSWQ+A6ZgNx/irTtAMD2 uJsARMxBtm2dDQJ3QCY/vbq2n/uAz4MXUzPnLtKRssgZymUMR+s2x7SJNTyo4HvR9zGR 3ApeIAbdgKr3hIenbDFRcq3oodh78A22K7G2eiJQhFipGD3WQjItontyNWxb3h/J7l4q HlUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=Npsm5bOJjjcIuADdoI2VTocPa/2BU7I+DV9Z9yFCxjA=; b=whBa8jEN0LfiSZpIIJ18TZ0JAE9FFBqvn+1H3QMeFfyZ/6NNR/nB6O2Cy6SxXv5gor 8cvC2KM/5G4rWwFSp91Aa32Nne20bHbv19M2nlL7zoPm3N3pW1glb6Td9/WxPRW9zpnL 8Qe8gME5ykCZteWmLlbFlh5imfG5lSWGNIjWljb2e/+rbMhXFSgOpV/i25sKZCAjv/uK 3C7OMSX5CVgs5ikf6bslb/vJ4gE9BlWEOYlVC0QnOIxgQFBijf0ZDdszJopHAk008Z35 5f2htlGiNEqObFUaStC//BncYzc+lAwwf/hY4FGQHUm2U8klOpaOXw4Qi6tsKb1JzjmX 037A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=KD4tTUQs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ot14si1296193ejb.493.2021.01.12.07.49.10; Tue, 12 Jan 2021 07:49:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=KD4tTUQs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391891AbhALPrn (ORCPT + 99 others); Tue, 12 Jan 2021 10:47:43 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:52042 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391882AbhALPrn (ORCPT ); Tue, 12 Jan 2021 10:47:43 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610466444; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=Npsm5bOJjjcIuADdoI2VTocPa/2BU7I+DV9Z9yFCxjA=; b=KD4tTUQsBDeF5U+zykyP5VRXW2Bb5oQF0z2pCUdqtd9ySBmMRcsbuc5WCZf1qQlfOZhYGVB3 mJWg00nLai2URJh1pAYrzlRnWrDfUKqWnHUsPaD/167JtP5cOoCBCQJDaqXCbyOFmOtWfNFo lnnm5suIq5HGkItj2G/gjxiOdpg= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5ffdc4858fb3cda82feebb06 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 12 Jan 2021 15:47:17 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 39015C43462; Tue, 12 Jan 2021 15:47:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C4861C433CA; Tue, 12 Jan 2021 15:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C4861C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pkshih Cc: "abaci-bugfix\@linux.alibaba.com" , "linux-wireless\@vger.kernel.org" , "davem\@davemloft.net" , "linux-kernel\@vger.kernel.org" , "kuba\@kernel.org" , "netdev\@vger.kernel.org" Subject: Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison References: <1610440409-73330-1-git-send-email-abaci-bugfix@linux.alibaba.com> <1610457587.2793.2.camel@realtek.com> Date: Tue, 12 Jan 2021 17:47:12 +0200 In-Reply-To: <1610457587.2793.2.camel@realtek.com> (pkshih@realtek.com's message of "Tue, 12 Jan 2021 13:20:21 +0000") Message-ID: <87y2gyrwcf.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Pkshih writes: > On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote: >> Fix the following coccicheck warning: >> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: >> WARNING: Comparison of 0/1 to bool variable >> >> Reported-by: Abaci Robot >> Signed-off-by: YANG LI >> > > I think your name of Signed-off-by should be "Yang Li". > > And, the subject prefix "rtlwifi: " is preferred. I can fix those during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches