Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C538DC433C6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     "Coelho\, Luciano" <luciano.coelho@intel.com>
Cc:     "tiwai\@suse.de" <tiwai@suse.de>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const
References: <20210112132449.22243-1-tiwai@suse.de>
        <20210112132449.22243-3-tiwai@suse.de> <87pn2arw69.fsf@codeaurora.org>
        <s5h4kjmqgxw.wl-tiwai@suse.de>
        <636fdc5b53b6f4855e25981e0454064524e6905d.camel@intel.com>
Date:   Wed, 13 Jan 2021 08:50:04 +0200
In-Reply-To: <636fdc5b53b6f4855e25981e0454064524e6905d.camel@intel.com>
        (Luciano Coelho's message of "Tue, 12 Jan 2021 17:13:59 +0000")
Message-ID: <87lfcxs543.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

"Coelho, Luciano" <luciano.coelho@intel.com> writes:

> On Tue, 2021-01-12 at 17:05 +0100, Takashi Iwai wrote:
>> On Tue, 12 Jan 2021 16:50:54 +0100,
>> Kalle Valo wrote:
>> > 
>> > Takashi Iwai <tiwai@suse.de> writes:
>> > 
>> > > The ucode TLV data may be read-only and should be treated as const
>> > > pointers, but currently a few code forcibly cast to the writable
>> > > pointer unnecessarily.  This gave developers a wrong impression as if
>> > > it can be modified, resulting in crashing regressions already a couple
>> > > of times.
>> > > 
>> > > This patch adds the const prefix to those cast pointers, so that such
>> > > attempt can be caught more easily in future.
>> > > 
>> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>> > 
>> > So this need to go to -next, right?
>> 
>> Yes, this isn't urgently needed for 5.11.
>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
>
>
>> > Does this depend on patch 1 or can
>> > this be applied independently?
>> 
>> It depends on the first patch, otherwise you'll get the warning in the
>> code changing the const data (it must warn -- that's the purpose of
>> this change :)
>> 
>> So, if applying to a separate branch is difficult, applying together
>> for 5.11 would be an option.
>
> It doesn't matter to me how you apply it.  Applying together is
> obviously going to be easier, but applying separately wouldn't be that
> hard either.  You'd just have to track when 1/2 went into net-next
> before applying this one.  Kalle's call.

Ok, I'll apply this to wireless-drivers-next after wireless-drivers is
merged to -next. It might take a while.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches