Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 Jan 2021 14:08:10 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Ryder Lee <ryder.lee@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>,
        Shayne Chen <shayne.chen@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] mt76: mt7915: simplify peer's TxBF capability check
Message-ID: <20210113130810.GA5528@lore-desk>
References: <287bbdb0193bd74069219b97199ba4ec72127bd8.1610539467.git.ryder.lee@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G"
Content-Disposition: inline
In-Reply-To: <287bbdb0193bd74069219b97199ba4ec72127bd8.1610539467.git.ryder.lee@mediatek.com>
Precedence: bulk


--k1lZvvs/B4yU6o8G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> This is a preliminary patch for implicit beamforming support.
>=20

Hi Ryber,

just few nitpicks inline.

Regards,
Lorenzo

> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
>  .../net/wireless/mediatek/mt76/mt7915/mcu.c   | 50 +++++++------------
>  1 file changed, 17 insertions(+), 33 deletions(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/ne=
t/wireless/mediatek/mt76/mt7915/mcu.c
> index 0baef70fc522..f38bc421ea8e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> @@ -66,9 +66,6 @@ struct mt7915_fw_region {
> =20
>  #define MCU_PATCH_ADDRESS		0x200000
> =20
> -#define MT_STA_BFER			BIT(0)
> -#define MT_STA_BFEE			BIT(1)
> -
>  #define FW_FEATURE_SET_ENCRYPT		BIT(0)
>  #define FW_FEATURE_SET_KEY_IDX		GENMASK(2, 1)
>  #define FW_FEATURE_OVERRIDE_ADDR	BIT(5)
> @@ -1948,16 +1945,23 @@ mt7915_mcu_sta_bfee_tlv(struct sk_buff *skb, stru=
ct ieee80211_sta *sta,
>  		bfee->fb_identity_matrix =3D true;
>  }
> =20
> -static u8
> -mt7915_mcu_sta_txbf_type(struct mt7915_phy *phy, struct ieee80211_vif *v=
if,
> -			 struct ieee80211_sta *sta)
> +static int
> +mt7915_mcu_add_txbf(struct mt7915_dev *dev, struct ieee80211_vif *vif,
> +		    struct ieee80211_sta *sta, bool enable)
>  {
> -	u8 type =3D 0;
> +	struct mt7915_vif *mvif =3D (struct mt7915_vif *)vif->drv_priv;
> +	struct mt7915_sta *msta =3D (struct mt7915_sta *)sta->drv_priv;
> +	struct mt7915_phy *phy;
> +	struct sk_buff *skb;
> +	int r, len;
> +	bool ebfee =3D 0, ebf =3D 0;
> =20
>  	if (vif->type !=3D NL80211_IFTYPE_STATION &&
>  	    vif->type !=3D NL80211_IFTYPE_AP)
>  		return 0;
> =20
> +	phy =3D mvif->band_idx ? mt7915_ext_phy(dev) : &dev->phy;
> +
>  	if (sta->he_cap.has_he) {
>  		struct ieee80211_he_cap_elem *pe;
>  		const struct ieee80211_he_cap_elem *ve;
> @@ -1970,12 +1974,12 @@ mt7915_mcu_sta_txbf_type(struct mt7915_phy *phy, =
struct ieee80211_vif *vif,
>  		if ((HE_PHY(CAP3_SU_BEAMFORMER, pe->phy_cap_info[3]) ||
>  		     HE_PHY(CAP4_MU_BEAMFORMER, pe->phy_cap_info[4])) &&
>  		    HE_PHY(CAP4_SU_BEAMFORMEE, ve->phy_cap_info[4]))
> -			type |=3D MT_STA_BFEE;
> +			ebfee =3D true;
> =20
>  		if ((HE_PHY(CAP3_SU_BEAMFORMER, ve->phy_cap_info[3]) ||
>  		     HE_PHY(CAP4_MU_BEAMFORMER, ve->phy_cap_info[4])) &&
>  		    HE_PHY(CAP4_SU_BEAMFORMEE, pe->phy_cap_info[4]))
> -			type |=3D MT_STA_BFER;
> +			ebf =3D true;
>  	} else if (sta->vht_cap.vht_supported) {
>  		struct ieee80211_sta_vht_cap *pc;
>  		struct ieee80211_sta_vht_cap *vc;
> @@ -1989,36 +1993,16 @@ mt7915_mcu_sta_txbf_type(struct mt7915_phy *phy, =
struct ieee80211_vif *vif,
>  		     IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE;
> =20
>  		if ((pc->cap & cr) && (vc->cap & ce))
> -			type |=3D MT_STA_BFEE;
> +			ebfee =3D true;

what about:
		ebfee =3D !!((pc->cap & cr) && (vc->cap & ce))

> =20
>  		if ((vc->cap & cr) && (pc->cap & ce))
> -			type |=3D MT_STA_BFER;
> -	} else if (sta->ht_cap.ht_supported) {
> -		/* TODO: iBF */
> +			ebf =3D true;

		ebfee =3D !!((vc->cap & cr) && (pc->cap & ce))
>  	}
> =20
> -	return type;
> -}
> -
> -static int
> -mt7915_mcu_add_txbf(struct mt7915_dev *dev, struct ieee80211_vif *vif,
> -		    struct ieee80211_sta *sta, bool enable)
> -{
> -	struct mt7915_vif *mvif =3D (struct mt7915_vif *)vif->drv_priv;
> -	struct mt7915_sta *msta =3D (struct mt7915_sta *)sta->drv_priv;
> -	struct mt7915_phy *phy;
> -	struct sk_buff *skb;
> -	int r, len;
> -	u8 type;
> -
> -	phy =3D mvif->band_idx ? mt7915_ext_phy(dev) : &dev->phy;
> -
> -	type =3D mt7915_mcu_sta_txbf_type(phy, vif, sta);
> -
>  	/* must keep each tag independent */
> =20
>  	/* starec bf */
> -	if (type & MT_STA_BFER) {
> +	if (ebf) {
>  		len =3D sizeof(struct sta_req_hdr) + sizeof(struct sta_rec_bf);
> =20
>  		skb =3D mt7915_mcu_alloc_sta_req(dev, mvif, msta, len);
> @@ -2034,7 +2018,7 @@ mt7915_mcu_add_txbf(struct mt7915_dev *dev, struct =
ieee80211_vif *vif,
>  	}
> =20
>  	/* starec bfee */
> -	if (type & MT_STA_BFEE) {
> +	if (ebfee) {
>  		len =3D sizeof(struct sta_req_hdr) + sizeof(struct sta_rec_bfee);
> =20
>  		skb =3D mt7915_mcu_alloc_sta_req(dev, mvif, msta, len);
> --=20
> 2.18.0
>=20

--k1lZvvs/B4yU6o8G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCX/7wuAAKCRA6cBh0uS2t
rG5UAQDzdZn08mrPnGeKlMsexdSLFqvhSnaygitAkF+1mW5jiQD9HKymQFg0JQK2
qx8DbwSzKMbQoZ3T3bqT1ZjBJzrL/AU=
=BaKt
-----END PGP SIGNATURE-----

--k1lZvvs/B4yU6o8G--