Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp599236pxb; Wed, 13 Jan 2021 11:06:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAZDr9x7UciJ6y2K94iO+KpcFtXEsu50PSn+YJ2xjO8250rrrQf0nVuyDk74BbXor7ZoDt X-Received: by 2002:a17:906:16d6:: with SMTP id t22mr2645338ejd.154.1610564779407; Wed, 13 Jan 2021 11:06:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610564779; cv=none; d=google.com; s=arc-20160816; b=aIi/xMMTGHkiMlXwLue1LSI0PaIVJHFndPd47Qq4wBx4vOVjYKFvYzt5My+F/Ia1ps P5KuwZbRHEC8kiteGr4tHKklYVmJjv3uGvxLpN8ualEieoPWS/5ow/vuP/bN+gF/Qgls qz6qSxWhWInD9fa2HOWf5vTSJkGUfhhekHtG+j4YrNOVZeXYoqTDLcqTlvMDNt494bX6 w6YrvC9xl5LOHAXsyz2xZo5BZfpCbYcb+bXy/JeV7n8r0GLqjhnubNgNuNO2ggst5lLt Q8jhCmuOuXp/Ndevz3Flmfz6Y/aVEOlqDHtfC2QG/jHFVdkRhUJDTgKNSReLNI96nSnU 85xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=3fA09py/40OlixsI/F8f6sBxbVt2+7TI6MlGgYkytMQ=; b=K1ikg7DGc9VV9ki7g7F1IndRj13KmobRUu8dERAk83NZrQ1q9VSrrJheMxzBciUb/f B1JSJYlsE6vZttvFgsZDXilKY8YIUX5NXYQs4IVuHTyLqIIlugFZiVBXJAa1F9WDiUhe uQFGGY44VrVor3dfGqBXx8XH4lmypFKxL4eLX40wWdp15QAEtBqpdpbF4ptrn2g5TiMC CUYAch810GcV/0aLWL5W4DMlpI6a860437Iw5IaPrD02FW1NrtLfRA9SIcOW6JLTqFI3 LFDAEkhd0z0EDA8yJ5t+KsDW4J96gZil14W0MI+GvRmoOutSAo43w5JviNfUA1zJ2c5+ mw6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=J1XRl7Gs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z9si1319640ejw.623.2021.01.13.11.05.54; Wed, 13 Jan 2021 11:06:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=J1XRl7Gs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728364AbhAMTFx (ORCPT + 99 others); Wed, 13 Jan 2021 14:05:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbhAMTFx (ORCPT ); Wed, 13 Jan 2021 14:05:53 -0500 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8ED3C061575 for ; Wed, 13 Jan 2021 11:05:12 -0800 (PST) Received: by mail-oi1-x235.google.com with SMTP id l207so3281702oib.4 for ; Wed, 13 Jan 2021 11:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3fA09py/40OlixsI/F8f6sBxbVt2+7TI6MlGgYkytMQ=; b=J1XRl7Gs/qvCRS5l9ulasgf3bmyBBklaLr41cPMU7vaPWbrKVIy47MVqRZ7K1mjs42 YzsokCMhLcZ4+rf/ZXLXc6kXkzSeKe9Ja7oLfsAdml+P7mmYo2lMTu6TEuIZxEpeqjeS od/WKjvtVSnej1Y/uSOmHEwsoNWiMe1JzjF1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3fA09py/40OlixsI/F8f6sBxbVt2+7TI6MlGgYkytMQ=; b=Mf9tL2o4lQLcfdRclMD2Oc3mQWtYpsZ1opne3ZbFjyAZUZeir60UK4669CDt5CuMNI gzP8TVen/oUCag97qDvpleYYp/MHoZQ6+HPvga+fylGfbhiGmxZWRjQD9ve0H0ztDogZ FzYkMsXUmf3rTtyF/+7JnZamL+jmzSxgiBlFbyDjGSlOvbRtvrBAliMzKbkDIYdxjfUH YN49e6ayvukuVQL5V+s4OL6uKj2m8IWSRxPvVs0+R9tQvCZ9YkVZUAw9bF64VrGeXlTQ WoR8SCJIVFnZdKFVAE4kwDNqvPitq7vlsBh1n7L+xj0LNg1yh415qebv2OhdNwcadVhl OmXg== X-Gm-Message-State: AOAM531NU1xJciB/vyTy7PLvEGe0UfuYzGVyZcSE8azggjxuKfVuw7Fl AVLnvlUCWXhCusbFDGQP3z8oUgNncTlx3A== X-Received: by 2002:aca:3145:: with SMTP id x66mr457258oix.29.1610564711903; Wed, 13 Jan 2021 11:05:11 -0800 (PST) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com. [209.85.167.173]) by smtp.gmail.com with ESMTPSA id c18sm572583oib.31.2021.01.13.11.05.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jan 2021 11:05:10 -0800 (PST) Received: by mail-oi1-f173.google.com with SMTP id q25so3244662oij.10 for ; Wed, 13 Jan 2021 11:05:10 -0800 (PST) X-Received: by 2002:aca:af4d:: with SMTP id y74mr430097oie.105.1610564709956; Wed, 13 Jan 2021 11:05:09 -0800 (PST) MIME-Version: 1.0 References: <20210113095101.16570-1-pkshih@realtek.com> <20210113095101.16570-5-pkshih@realtek.com> In-Reply-To: <20210113095101.16570-5-pkshih@realtek.com> From: Brian Norris Date: Wed, 13 Jan 2021 11:04:57 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/7] rtw88: replace tx tasklet with tx work To: Ping-Ke Shih Cc: Yan-Hsuan Chuang , Kalle Valo , linux-wireless , phhuang@realtek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jan 13, 2021 at 1:53 AM Ping-Ke Shih wrote: > > From: Po-Hao Huang > > Move tx tasklet to thread, by this we can reduce time spent on > waiting for schedule and have better efficiency. > > Signed-off-by: Po-Hao Huang > Signed-off-by: Ping-Ke Shih I'm curious, why a bare kthread and not just a (WQ_HIGHPRI?) workqueue? It seems like you're sort of reimplementing some of the workqueue semantics with your SCHEDULED and RUNNING flags, when queue_work() would do that for you. Brian