Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mt76: testmode: add support to set user-defined spe index
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
References: <20210105054124.5946-1-shayne.chen@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <a2d8b06c-f4d7-b460-f988-8fe7b9b50540@nbd.name>
Date:   Thu, 14 Jan 2021 10:33:45 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210105054124.5946-1-shayne.chen@mediatek.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-01-05 06:41, Shayne Chen wrote:
> Add spatial extension (spe) index as a configurable parameter in testmode.
> This is used for specifically configuring TX path, such as different
> WF TX priority, number of antennas and spatial streams.
> 
> If spe_idx is not set, TX path depends on tx_antenna_mask; otherwise,
> both spe_idx and tx_antenna_mask are referenced to decide TX path.
> 
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76.h         |  1 +
>  .../net/wireless/mediatek/mt76/mt7915/testmode.c  | 15 ++++++++++-----
>  drivers/net/wireless/mediatek/mt76/testmode.c     |  4 ++++
>  drivers/net/wireless/mediatek/mt76/testmode.h     |  2 ++
>  4 files changed, 17 insertions(+), 5 deletions(-)
> 
> index 7efad685a17c..f215b377d7fb 100644
> --- a/drivers/net/wireless/mediatek/mt76/testmode.h
> +++ b/drivers/net/wireless/mediatek/mt76/testmode.h
> @@ -29,6 +29,7 @@
>   * @MT76_TM_ATTR_TX_LTF: packet tx LTF, set 0 to 2 for 1x, 2x, and 4x LTF (u8)
>   *
>   * @MT76_TM_ATTR_TX_ANTENNA: tx antenna mask (u8)
> + * @MT76_TM_ATTR_TX_SPE_IDX: tx spatial extension index (u8)
>   * @MT76_TM_ATTR_TX_POWER_CONTROL: enable tx power control (u8)
>   * @MT76_TM_ATTR_TX_POWER: per-antenna tx power array (nested, u8 attrs)
>   *
> @@ -56,6 +57,7 @@ enum mt76_testmode_attr {
>  	MT76_TM_ATTR_TX_LTF,
>  
>  	MT76_TM_ATTR_TX_ANTENNA,
> +	MT76_TM_ATTR_TX_SPE_IDX,In order to avoid breaking the ABI, please only add new entries at the
end of the enum, above the "keep last" line.
I'll fix it up locally this time.

- Felix