Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp489572pxb; Thu, 14 Jan 2021 10:39:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJw89ThxW9SO6WTiM5GI4OnCCYgGGxIDHuzrRJw4jYXWbrAYWg399XXfN6xVtiWIJTngaJNk X-Received: by 2002:a17:906:8292:: with SMTP id h18mr6470286ejx.481.1610649580307; Thu, 14 Jan 2021 10:39:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610649580; cv=none; d=google.com; s=arc-20160816; b=Dso7V7aYEEA6Qz2DBmB6/bn8FUkF1yyBY+2CEUKShyqvwCWdt+gf5irsssUxTQVlZB 9okk+QDHw94EYT8smDLbTzSlwR5hUKWqGi12CL28w92gTjBw0IqZO/zWRZBSs8c83NuX i30NahNzz4USi0uy4MwVXoudpOR3nyGiFnFEITvyREajunZYsRS5CiSFpPDbozwMoIRJ 21/RJwiR1kC+V///vq9Sk8pH8bggO03/06zhsWRc0Z9TA+qVxORfQQ8k1EJPn09hlzzP n3tUzuEn7+aXeK4mvOqv8z2rOOM/qC1HycEsdSve25Yx3x0LLM/JsHaHZ+gEjEOaF6Ty Lnsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=SZh/mWJSzO+TetDOcszyEvmZmAyAbAOQdCJcm1GsPiU=; b=xLDfVWa9wNbsu3mWb3iZxfkrCgCpyh2Or7fvwLlffc4jR50tvLw6Hz2Fnw/l6cQMzB Uqk6B4PeUN3ym+SKL/ok/CBh6Cp3KBIj1TVfEU/OtURK5EeTtZzIJYqJmPhJYk0hXLV6 rTkmH+7mIR7F4OVn7jo+Dpz122LIkruOF0nei5jODuyK9RpwJEap8DVpWy6BQWK5lZTU zAdmn/7fJrLscGPj8RXpq9H0RqDl8RZlXvccVG2kDEyba4lxUYhmq97bbaet9foSGDPw zdXGZ++2p6AshKUeasrEWhCqT+YrpNAB8n01D1/5Gsqbb7Y26Q/GMazn8gFdZ/a1I3zD Wwpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AesTqJo1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si2728430ejd.696.2021.01.14.10.39.14; Thu, 14 Jan 2021 10:39:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AesTqJo1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728761AbhANSfN (ORCPT + 99 others); Thu, 14 Jan 2021 13:35:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbhANSfM (ORCPT ); Thu, 14 Jan 2021 13:35:12 -0500 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52BFBC061575 for ; Thu, 14 Jan 2021 10:34:32 -0800 (PST) Received: by mail-oi1-x235.google.com with SMTP id w124so6919000oia.6 for ; Thu, 14 Jan 2021 10:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SZh/mWJSzO+TetDOcszyEvmZmAyAbAOQdCJcm1GsPiU=; b=AesTqJo1ng30NLzIT/3qy8fktkiK/XYb7DNqu8866RQ7bZl7Tr/Dhzb8N7A5lPp+8A l4kg16Q0q/j+T0XcTdqz1MYonF2SbruApQfhG8vKGCejUPCoMSYOOL8a3Ox1CBe4CKci 1R3i3JUAPIoEwhyQfAx62YToF3pnHcmyuiYA8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SZh/mWJSzO+TetDOcszyEvmZmAyAbAOQdCJcm1GsPiU=; b=MlRSqSTQmaxUySiF9K+Lijmd0rYT+PZ4ciHY8PAeDu8WvZ7aHu6A6ahzYSQDeDinV/ PL/mqIR2qjlCZe5k8RyHeIGR/31BGma+nimwyPwFBuB6S1XYrqdLXPruefXpQPH7LIau jjdEb8lg7a7f689zWylPZ3E3vjXe3dDxVYVWiyVHycqYtcg5E5rVnfZ8ekLLgtsGoG57 GC0Wyi/ZCQlSrPr8OT6QVf9LR3YQkUKIWJUgTb/l4bbux/0DscJ+DE8GbQLwpNsvOxck 07WXoQkJBdaRvAUDvKDVzUKfpSOwrMrfx4LqcKXO13V0CKu13WCwwgAIEKXgEpaCxCy2 Esrg== X-Gm-Message-State: AOAM533e/IsLoaPFmW6Wiwu0gJXIgDWLcPfr8C8maBKr647mfzT5huHj 6LuzSs76SB5njg7beMyfVPO0HzfFXjbw3g== X-Received: by 2002:a05:6808:2cb:: with SMTP id a11mr3418277oid.93.1610649271393; Thu, 14 Jan 2021 10:34:31 -0800 (PST) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com. [209.85.167.179]) by smtp.gmail.com with ESMTPSA id z3sm1207800ota.80.2021.01.14.10.34.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jan 2021 10:34:30 -0800 (PST) Received: by mail-oi1-f179.google.com with SMTP id l207so6940212oib.4 for ; Thu, 14 Jan 2021 10:34:30 -0800 (PST) X-Received: by 2002:aca:d696:: with SMTP id n144mr3260842oig.77.1610649269609; Thu, 14 Jan 2021 10:34:29 -0800 (PST) MIME-Version: 1.0 References: <20210114010950.3316-1-pkshih@realtek.com> <20210114010950.3316-5-pkshih@realtek.com> In-Reply-To: <20210114010950.3316-5-pkshih@realtek.com> From: Brian Norris Date: Thu, 14 Jan 2021 10:34:18 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RESEND v3 4/8] rtw88: replace tx tasklet with tx work To: Ping-Ke Shih Cc: Yan-Hsuan Chuang , Kalle Valo , linux-wireless , phhuang@realtek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jan 13, 2021 at 5:45 PM Ping-Ke Shih wrote: > > From: Po-Hao Huang > > Move tx tasklet to thread, by this we can reduce time spent on > waiting for schedule and have better efficiency. > > Signed-off-by: Po-Hao Huang > Signed-off-by: Ping-Ke Shih I'll note here for completeness: I suggested considering a workqueue on v2 (I hadn't yet received v3), and Realtek was planning on considering that. Brian